From: Dan Carpenter Date: Thu, 4 Jun 2015 09:04:12 +0000 (+0300) Subject: w1: use correct lock on error in w1_seq_show() X-Git-Tag: omap-for-v4.2/fixes-rc1^2~94^2~19 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0c6d5c89a112620d2166b8d042d3d69bb42b626c;p=pandora-kernel.git w1: use correct lock on error in w1_seq_show() I noticed there was a problem here because Smatch complained: drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn: inconsistent returns 'mutex:&sl->master->mutex'. Locked on: line 416 Unlocked on: line 413 The problem is that we lock ->mutex but we unlock ->bus_mutex on error. David Fries says that ->bus_mutex is correct and ->mutex is incorrect. Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm') Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polyakov Signed-off-by: Greg Kroah-Hartman --- Reading git-diff-tree failed