From: Julien Brunel <brunel@diku.dk>
Date: Fri, 29 Aug 2008 09:08:32 +0000 (+0200)
Subject: UBIFS: use an IS_ERR test rather than a NULL test
X-Git-Tag: Release-2010-05/1~3^2~196
X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bffaf4b215913ce43a9d1a8daf0d7dadf260495;p=pandora-kernel.git

UBIFS: use an IS_ERR test rather than a NULL test

In case of error, the function kthread_create returns an ERR pointer,
but never returns a NULL pointer. So a NULL test that comes before an
IS_ERR test should be deleted.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@match_bad_null_test@
expression x, E;
statement S1,S2;
@@
x = kthread_create(...)
... when != x = E
* if (x == NULL)
S1 else S2
// </smpl>

Signed-off-by: Julien Brunel <brunel@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---

Reading git-diff-tree failed