From: Manfred Spraul Date: Tue, 2 Dec 2014 23:59:34 +0000 (-0800) Subject: ipc/sem.c: fully initialize sem_array before making it visible X-Git-Tag: v3.2.72~15 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bdf1e820160cdeb16cba1c5ea6892ae982a6587;p=pandora-kernel.git ipc/sem.c: fully initialize sem_array before making it visible commit e8577d1f0329d4842e8302e289fb2c22156abef4 upstream. ipc_addid() makes a new ipc identifier visible to everyone. New objects start as locked, so that the caller can complete the initialization after the call. Within struct sem_array, at least sma->sem_base and sma->sem_nsems are accessed without any locks, therefore this approach doesn't work. Thus: Move the ipc_addid() to the end of the initialization. Signed-off-by: Manfred Spraul Reported-by: Rik van Riel Acked-by: Rik van Riel Acked-by: Davidlohr Bueso Acked-by: Rafael Aquini Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [bwh: Backported to 3.2: - Adjust context - The error path being moved looks a little different] Signed-off-by: Ben Hutchings --- Reading git-diff-tree failed