From: Julia Lawall Date: Sun, 21 Aug 2011 11:18:45 +0000 (+0200) Subject: sound/soc/mxs/mxs-saif.c: add missing kfree X-Git-Tag: v3.2-rc1~127^2~2^2~1^2~70 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0bb98ba2b045e53b4724f34509455b7653c329d3;p=pandora-kernel.git sound/soc/mxs/mxs-saif.c: add missing kfree Move the test on pdev->id before the kzalloc to avoid requiring kfree when the test fails. This fix was suggested by Wolfram Sang. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != kfree(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 kfree(x); ... return ...; } ) // Signed-off-by: Julia Lawall Acked-by: Dong Aisheng Reviewed-by: Wolfram Sang Acked-by: Liam Girdwood Signed-off-by: Mark Brown --- Reading git-diff-tree failed