From: Herton Ronaldo Krzesinski Date: Fri, 19 Mar 2010 17:58:23 +0000 (-0300) Subject: Revert "V4L/DVB (11906): saa7134: Use v4l bounding/alignment function" X-Git-Tag: v2.6.35-rc1~480^2~206 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a062033f727dc041691bfd768f4cf0598f559a1;p=pandora-kernel.git Revert "V4L/DVB (11906): saa7134: Use v4l bounding/alignment function" This reverts commit bc52d6eb44de8f19934768d4d10d19fdbdc99950. On newer kernels, a saa7134 board stopped to display TV video output properly. After a bisect, I found it as the commit causing the issue. Turns out that v4l_bound_align_image isn't doing the same bounding calculation as manually done previously in saa7134_try_fmt_vid_cap. What isn't equal is the calculation done in clamp align, while previously it did "f->fmt.pix.width &= ~0x03", clamp_align function does "Round to nearest aligned value" as stated in the comment, which yields a different result. If I comment the round calculation in clamp_align like this: "x = (x /*+ (1 << (align - 1))*/) & mask", I get it fixed too, because this way the calculation is the same then. Signed-off-by: Herton Ronaldo Krzesinski Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed