From: Hans Verkuil Date: Fri, 2 Mar 2012 15:41:25 +0000 (-0300) Subject: [media] v4l2-ctrls: v4l2_ctrl_add_handler should add all refs X-Git-Tag: v3.4-rc1~110^2^2~110 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=072e660257ee26e4f4defd836b1e1fa23d68de32;p=pandora-kernel.git [media] v4l2-ctrls: v4l2_ctrl_add_handler should add all refs Currently v4l2_ctrl_add_handler adds only the controls that are owned by the handler. This is wrong. Instead all controls, whether owned or not, should be added. This is also implied by the v4l2-controls.txt documentation and it is clearly the right thing to do. The only reason this was never noticed before is because we never did this. Only recent changes in ivtv made this error visible because there a third handler layer was added (handler A inherits from handler B which inherits from C, D and E). Without this change handler A only sees the controls owned by handler B and the controls from C, D and E are missing. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed