From: Mauro Carvalho Chehab Date: Wed, 3 Sep 2014 23:44:04 +0000 (-0300) Subject: [media] ngene: properly handle __user ptr X-Git-Tag: fixes-against-v3.18-rc2~130^2^2~229 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04da2daee383391954b34e7d0fe0281d75447d61;p=pandora-kernel.git [media] ngene: properly handle __user ptr Sparse is complaining about ngene's bad usage of a __user ptr: >> drivers/media/pci/ngene/ngene-dvb.c:62:48: sparse: incorrect type in argument 2 (different address spaces) drivers/media/pci/ngene/ngene-dvb.c:62:48: expected unsigned char const [usertype] *buf drivers/media/pci/ngene/ngene-dvb.c:62:48: got char const [noderef] *buf As this is intercepting a .write() file ops, we can't just memcpy. We need to use copy_from_user. Reported-by: kbuild test robot Signed-off-by: Mauro Carvalho Chehab --- Reading git-diff-tree failed