From: John Johansen Date: Sat, 28 Aug 2010 01:33:28 +0000 (-0700) Subject: AppArmor: Fix splitting an fqname into separate namespace and profile names X-Git-Tag: v2.6.36-rc4~76^2~2 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04ccd53f09741c4bc54ab36db000bc1383e4812e;p=pandora-kernel.git AppArmor: Fix splitting an fqname into separate namespace and profile names As per Dan Carpenter If we have a ns name without a following profile then in the original code it did "*ns_name = &name[1];". "name" is NULL so "*ns_name" is 0x1. That isn't useful and could cause an oops when this function is called from aa_remove_profiles(). Beyond this the assignment of the namespace name was wrong in the case where the profile name was provided as it was being set to &name[1] after name = skip_spaces(split + 1); Move the ns_name assignment before updating name for the split and also add skip_spaces, making the interface more robust. Signed-off-by: John Johansen Signed-off-by: James Morris --- Reading git-diff-tree failed