From: Rusty Russell Date: Mon, 28 Jul 2008 17:16:29 +0000 (-0500) Subject: Hotplug CPU: don't check cpu_online after take_cpu_down X-Git-Tag: v2.6.27-rc1~30^2~3 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04321587584272f4e8b9818f319f40caf8eeee13;p=pandora-kernel.git Hotplug CPU: don't check cpu_online after take_cpu_down Akinobu points out that if take_cpu_down() succeeds, the cpu must be offline. Remove the cpu_online() check, and put a BUG_ON(). Quoting Akinobu Mita: Actually the cpu_online() check was necessary before appling this stop_machine: simplify patch. With old __stop_machine_run(), __stop_machine_run() could succeed (return !IS_ERR(p) value) even if take_cpu_down() returned non-zero value. The return value of take_cpu_down() was obtained through kthread_stop().. Signed-off-by: Rusty Russell Cc: "Akinobu Mita" --- Reading git-diff-tree failed