From: Rasmus Villemoes Date: Wed, 4 Jun 2025 19:56:08 +0000 (+0200) Subject: arm: imx: remove unnecessary volatile qualifiers from "save gd" variables X-Git-Tag: v2025.10-rc1~118^2~18^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01869368c08278d19a0b7ec744013bc88afcf09a;p=pandora-u-boot.git arm: imx: remove unnecessary volatile qualifiers from "save gd" variables Now that the global gd pointer is no longer volatile-qualified, there's no reason for the temporary variables used for saving/restoring it to have that qualifier. Signed-off-by: Rasmus Villemoes Tested-by: Anshul Dalal --- diff --git a/arch/arm/mach-imx/hab.c b/arch/arm/mach-imx/hab.c index 600092389a3..ab5861578e5 100644 --- a/arch/arm/mach-imx/hab.c +++ b/arch/arm/mach-imx/hab.c @@ -74,7 +74,7 @@ static int verify_ivt_header(struct ivt_header *ivt_hdr) #define FSL_SIP_HAB_REPORT_STATUS 0x04 #define FSL_SIP_HAB_FAILSAFE 0x05 #define FSL_SIP_HAB_CHECK_TARGET 0x06 -static volatile gd_t *gd_save; +static gd_t *gd_save; #endif static inline void save_gd(void) diff --git a/arch/arm/mach-imx/imx9/scmi/soc.c b/arch/arm/mach-imx/imx9/scmi/soc.c index d2b0455bff9..d68a1166deb 100644 --- a/arch/arm/mach-imx/imx9/scmi/soc.c +++ b/arch/arm/mach-imx/imx9/scmi/soc.c @@ -67,7 +67,7 @@ int mmc_get_env_dev(void) u16 boot_type; u8 boot_instance; - volatile gd_t *pgd = gd; + gd_t *pgd = gd; rom_passover_t *rdata; #if IS_ENABLED(CONFIG_XPL_BUILD) @@ -675,7 +675,7 @@ enum imx9_soc_voltage_mode soc_target_voltage_mode(void) #if IS_ENABLED(CONFIG_SCMI_FIRMWARE) enum boot_device get_boot_device(void) { - volatile gd_t *pgd = gd; + gd_t *pgd = gd; int ret; u16 boot_type; u8 boot_instance; diff --git a/arch/arm/mach-imx/romapi.c b/arch/arm/mach-imx/romapi.c index ff0522c2d11..c6fe4d8858e 100644 --- a/arch/arm/mach-imx/romapi.c +++ b/arch/arm/mach-imx/romapi.c @@ -9,7 +9,7 @@ DECLARE_GLOBAL_DATA_PTR; u32 rom_api_download_image(u8 *dest, u32 offset, u32 size) { u32 xor = (uintptr_t)dest ^ offset ^ size; - volatile gd_t *sgd = gd; + gd_t *sgd = gd; u32 ret; ret = g_rom_api->download_image(dest, offset, size, xor); @@ -21,7 +21,7 @@ u32 rom_api_download_image(u8 *dest, u32 offset, u32 size) u32 rom_api_query_boot_infor(u32 info_type, u32 *info) { u32 xor = info_type ^ (uintptr_t)info; - volatile gd_t *sgd = gd; + gd_t *sgd = gd; u32 ret; ret = g_rom_api->query_boot_infor(info_type, info, xor); @@ -34,7 +34,7 @@ extern struct rom_api *g_rom_api; enum boot_device get_boot_device(void) { - volatile gd_t *pgd = gd; + gd_t *pgd = gd; int ret; u32 boot; u16 boot_type;