From: Pablo Neira Ayuso Date: Wed, 5 Sep 2012 16:24:55 +0000 (+0200) Subject: netfilter: fix crash during boot if NAT has been compiled built-in X-Git-Tag: omap-for-v3.7-rc1/fixes-cpufreq-signed~47^2~177^2~4 X-Git-Url: http://git.openpandora.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=00545bec9412d130c77f72a08d6c8b6ad21d4a1e;p=pandora-kernel.git netfilter: fix crash during boot if NAT has been compiled built-in (c7232c9 netfilter: add protocol independent NAT core) introduced a problem that leads to crashing during boot due to NULL pointer dereference. It seems that xt_nat calls xt_register_target() before xt_init(): net/netfilter/x_tables.c:static struct xt_af *xt; is NULL and we crash on xt_register_target(struct xt_target *target) { u_int8_t af = target->family; int ret; ret = mutex_lock_interruptible(&xt[af].mutex); ... Fix this by changing the linking order, to make sure that x_tables comes before xt_nat. Reported-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- Reading git-diff-tree failed