gpe-bootsplash-themes: add FIXMEs and fix SRC_URI for theme-e (file+wildcards is...

diff --git a/packages/gpe-bootsplash/gpe-bootsplash-theme-e.bb b/packages/gpe-bootsplash/gpe-bootsplash-theme-e.bb
index e95c09b..5eeee0f 100644 (file)
--- a/packages/gpe-bootsplash/gpe-bootsplash-theme-e.bb
+++ b/packages/gpe-bootsplash/gpe-bootsplash-theme-e.bb
@@ -3,20 +3,19 @@ SECTION = "base"
 PRIORITY = "optional"
 MAINTAINER = "Matthias 'CoreDump' Hentges  <oe@hentges.net>"
 LICENSE = "GPL"
-
 DEPENDS = "gpe-bootsplash"
 RDEPENDS = "gpe-bootsplash"
-
-PR = "r0"
+PR = "r1"
 
 export THEME = "e"
 
-SRC_URI = "file://*.svg"
-
-FILES_${PN} = "/usr/share/gpe/splash-${THEME}-*"
+SRC_URI = "file://splash-e-portrait.svg \
+           file://splash-e-landscape.svg"
 
+#FIXME: Please use $datadir instead of /usr/share
+#FIXME: please use an gpe-bootsplash-theme.inc to reduce duplication
 
-do_install(){
+do_install() {
        install -d "${D}/usr/share/gpe" 
        install -m 0644 ${WORKDIR}/splash-${THEME}* ${D}/usr/share/gpe
 }
@@ -30,3 +29,5 @@ pkg_postrm() {
        update-alternatives --remove bootsplash-l /usr/share/gpe/splash-${THEME}-landscape.svg
        update-alternatives --remove bootsplash-p /usr/share/gpe/splash-${THEME}-portrait.svg   
 }
+
+FILES_${PN} = "/usr/share/gpe/splash-${THEME}-*"

diff --git a/packages/gpe-bootsplash/gpe-bootsplash-theme-opie.bb b/packages/gpe-bootsplash/gpe-bootsplash-theme-opie.bb
index dff92e7..9aa2e9b 100644 (file)
--- a/packages/gpe-bootsplash/gpe-bootsplash-theme-opie.bb
+++ b/packages/gpe-bootsplash/gpe-bootsplash-theme-opie.bb
@@ -3,20 +3,17 @@ SECTION = "base"
 PRIORITY = "optional"
 MAINTAINER = "Matthias 'CoreDump' Hentges  <oe@hentges.net>"
 LICENSE = "GPL"
-
 DEPENDS = "gpe-bootsplash"
 RDEPENDS = "gpe-bootsplash"
-
-PR = "r0"
+PR = "r1"
 
 export THEME = "opie"
 
 SRC_URI = "file://*.svg \
-          file://*${THEME}*logo*"
-
-FILES_${PN} = "/usr/share/gpe/splash-${THEME}-*\
-              /usr/share/gpe/${THEME}-logo.png"
+           file://*${THEME}*logo*"
 
+#FIXME: please use $datadir instead of /usr/share
+#FIXME: please use an gpe-bootsplash-theme.inc to reduce duplication
 
 do_install(){
        install -d "${D}/usr/share/gpe" 
@@ -33,3 +30,7 @@ pkg_postrm() {
        update-alternatives --remove bootsplash-l /usr/share/gpe/splash-${THEME}-landscape.svg
        update-alternatives --remove bootsplash-p /usr/share/gpe/splash-${THEME}-portrait.svg   
 }
+
+FILES_${PN} = "/usr/share/gpe/splash-${THEME}-* \
+               /usr/share/gpe/${THEME}-logo.png"
+