git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cd89783
)
drm/nouveau/fan: fix selection of fan speed when fan->get returns an error
author
Marcin Slusarz
<marcin.slusarz@gmail.com>
Sun, 27 Jan 2013 14:51:09 +0000
(15:51 +0100)
committer
Ben Skeggs
<bskeggs@redhat.com>
Wed, 20 Feb 2013 06:00:36 +0000
(16:00 +1000)
fan->get returns int, but we write it to unsigned variable, and then check
whether it's >= 0 (it always is)
Found by smatch:
drivers/gpu/drm/nouveau/core/subdev/therm/fan.c:61 nouveau_fan_update() warn: always true condition '(duty >= 0) => (0-u32max >= 0)'
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
No differences found