git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4e2061b
)
can: xilinx_can: fix comparison of unsigned variable
author
Sudip Mukherjee
<sudipm.mukherjee@gmail.com>
Tue, 18 Nov 2014 13:47:07 +0000
(19:17 +0530)
committer
Marc Kleine-Budde
<mkl@pengutronix.de>
Tue, 18 Nov 2014 16:47:49 +0000
(17:47 +0100)
The variable err was of the type u32. It was being compared with < 0, and being
an unsigned variable the comparison would have been always false.
Moreover, err was getting the return value from set_reset_mode() and
xcan_set_bittiming(), and both are returning int.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/xilinx_can.c
patch
|
blob
|
history
diff --cc
drivers/net/can/xilinx_can.c
Simple merge