efi_loader: avoid writing message in Exit() boot service
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Tue, 26 Nov 2024 23:40:17 +0000 (00:40 +0100)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sun, 5 Jan 2025 01:30:47 +0000 (02:30 +0100)
We should not write messages in UEFI API functions. This may lead to
incorrect screen layout in UEFI application.

For single statements after if clause we don't need braces.

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
lib/efi_loader/efi_boottime.c

index 080e7f7..38b0af9 100644 (file)
@@ -3495,10 +3495,9 @@ static efi_status_t EFIAPI efi_exit(efi_handle_t image_handle,
        if (IS_ENABLED(CONFIG_EFI_TCG2_PROTOCOL)) {
                if (image_obj->image_type == IMAGE_SUBSYSTEM_EFI_APPLICATION) {
                        ret = efi_tcg2_measure_efi_app_exit();
-                       if (ret != EFI_SUCCESS) {
-                               log_warning("tcg2 measurement fails(0x%lx)\n",
-                                           ret);
-                       }
+                       if (ret != EFI_SUCCESS)
+                               log_debug("tcg2 measurement fails (0x%lx)\n",
+                                         ret);
                }
        }