ARM: omap2: gpmc: Remove redundant chip select out of range check
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Tue, 12 Feb 2013 19:22:24 +0000 (16:22 -0300)
committerJon Hunter <jon-hunter@ti.com>
Mon, 1 Apr 2013 19:53:39 +0000 (14:53 -0500)
This check is done before the call to gpmc_cs_reserved() and
gpmc_cs_set_reserved() and it's redundant to do it again in each
function. This simplifies the code a bit.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Reviewed-by: Jon Hunter <jon-hunter@ti.com>
Signed-off-by: Jon Hunter <jon-hunter@ti.com>
arch/arm/mach-omap2/gpmc.c

index 7c122bb..586dba7 100644 (file)
@@ -441,22 +441,14 @@ static int gpmc_cs_mem_enabled(int cs)
        return l & GPMC_CONFIG7_CSVALID;
 }
 
-static int gpmc_cs_set_reserved(int cs, int reserved)
+static void gpmc_cs_set_reserved(int cs, int reserved)
 {
-       if (cs > GPMC_CS_NUM)
-               return -ENODEV;
-
        gpmc_cs_map &= ~(1 << cs);
        gpmc_cs_map |= (reserved ? 1 : 0) << cs;
-
-       return 0;
 }
 
 static bool gpmc_cs_reserved(int cs)
 {
-       if (cs > GPMC_CS_NUM)
-               return true;
-
        return gpmc_cs_map & (1 << cs);
 }