usb: gadget: musb: Fix duplicate ops assignment in ti_musb_peripheral
authorKory Maincent <kory.maincent@bootlin.com>
Wed, 11 Jun 2025 17:10:30 +0000 (19:10 +0200)
committerMattijs Korpershoek <mkorpershoek@kernel.org>
Mon, 16 Jun 2025 07:00:55 +0000 (09:00 +0200)
Remove duplicate .ops assignment that was overriding the correct
ti_musb_gadget_ops with musb_usb_ops (host ops) in the ti_musb_peripheral
driver. This was causing U-Boot crashes when trying to call the
handle_interrupts operation since the wrong ops structure was being used.

Fixes: 7d98dbcc3dc ("usb: musb-new: Add support for DM_USB")
Fixes: 281eaf1ed83a ("usb: gadget: musb: Convert interrupt handling to usb_gadget_generic_ops")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Link: https://lore.kernel.org/r/20250611171031.840277-1-kory.maincent@bootlin.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
drivers/usb/musb-new/ti-musb.c

index ec1baa9..967d095 100644 (file)
@@ -282,7 +282,6 @@ U_BOOT_DRIVER(ti_musb_peripheral) = {
        .ops    = &ti_musb_gadget_ops,
        .probe = ti_musb_peripheral_probe,
        .remove = ti_musb_peripheral_remove,
-       .ops    = &musb_usb_ops,
        .plat_auto      = sizeof(struct ti_musb_plat),
        .priv_auto      = sizeof(struct ti_musb_peripheral),
        .flags = DM_FLAG_PRE_RELOC,