pinctrl: imx: Inline struct imx_pinctrl_soc_info access into probe
authorMarek Vasut <marex@denx.de>
Fri, 24 Jan 2025 14:50:53 +0000 (15:50 +0100)
committerFabio Estevam <festevam@gmail.com>
Sat, 25 Jan 2025 12:06:32 +0000 (09:06 -0300)
The probe function is identical across all the pinctrl drivers.
Inline the imx_pinctrl_soc_info access into imx_pinctrl_probe()
and drop all the duplicate probe functions. No functional change.

Signed-off-by: Marek Vasut <marex@denx.de>
12 files changed:
drivers/pinctrl/nxp/pinctrl-imx.c
drivers/pinctrl/nxp/pinctrl-imx.h
drivers/pinctrl/nxp/pinctrl-imx5.c
drivers/pinctrl/nxp/pinctrl-imx6.c
drivers/pinctrl/nxp/pinctrl-imx7.c
drivers/pinctrl/nxp/pinctrl-imx7ulp.c
drivers/pinctrl/nxp/pinctrl-imx8.c
drivers/pinctrl/nxp/pinctrl-imx8m.c
drivers/pinctrl/nxp/pinctrl-imx8ulp.c
drivers/pinctrl/nxp/pinctrl-imx93.c
drivers/pinctrl/nxp/pinctrl-imxrt.c
drivers/pinctrl/nxp/pinctrl-vf610.c

index 3443cf4..2d142c3 100644 (file)
@@ -194,9 +194,10 @@ int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config)
        return 0;
 }
 
-int imx_pinctrl_probe(struct udevice *dev,
-                     struct imx_pinctrl_soc_info *info)
+int imx_pinctrl_probe(struct udevice *dev)
 {
+       struct imx_pinctrl_soc_info *info =
+               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
        struct imx_pinctrl_priv *priv = dev_get_priv(dev);
        struct ofnode_phandle_args arg;
        ofnode node = dev_ofnode(dev);
index 02f05fd..b25f798 100644 (file)
@@ -48,7 +48,7 @@ struct imx_pinctrl_priv {
 
 #define IOMUXC_CONFIG_SION     (0x1 << 4)
 
-int imx_pinctrl_probe(struct udevice *dev, struct imx_pinctrl_soc_info *info);
+int imx_pinctrl_probe(struct udevice *dev);
 
 int imx_pinctrl_remove(struct udevice *dev);
 
index 56f0e17..544c509 100644 (file)
 
 static struct imx_pinctrl_soc_info imx5_pinctrl_soc_info __section(".data");
 
-static int imx5_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx5_pinctrl_match[] = {
        {
                .compatible = "fsl,imx53-iomuxc",
@@ -39,7 +31,7 @@ U_BOOT_DRIVER(imx5_pinctrl) = {
        .name = "imx5-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx5_pinctrl_match),
-       .probe = imx5_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx5_pinctrl_ops,
index 23b5566..ae16ce7 100644 (file)
@@ -20,14 +20,6 @@ static struct imx_pinctrl_soc_info imx6_snvs_pinctrl_soc_info = {
        .flags = ZERO_OFFSET_VALID,
 };
 
-static int imx6_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx6_pinctrl_match[] = {
        { .compatible = "fsl,imx6q-iomuxc", .data = (ulong)&imx6_pinctrl_soc_info },
        { .compatible = "fsl,imx6dl-iomuxc", .data = (ulong)&imx6_pinctrl_soc_info },
@@ -48,7 +40,7 @@ U_BOOT_DRIVER(fsl_imx6q_iomuxc) = {
        .name = "fsl_imx6q_iomuxc",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx6_pinctrl_match),
-       .probe = imx6_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx6_pinctrl_ops,
index faccd2e..87a3583 100644 (file)
@@ -14,14 +14,6 @@ static struct imx_pinctrl_soc_info imx7_lpsr_pinctrl_soc_info = {
        .flags = ZERO_OFFSET_VALID,
 };
 
-static int imx7_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx7_pinctrl_match[] = {
        { .compatible = "fsl,imx7d-iomuxc", .data = (ulong)&imx7_pinctrl_soc_info },
        { .compatible = "fsl,imx7d-iomuxc-lpsr", .data = (ulong)&imx7_lpsr_pinctrl_soc_info },
@@ -36,7 +28,7 @@ U_BOOT_DRIVER(imx7_pinctrl) = {
        .name = "imx7-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx7_pinctrl_match),
-       .probe = imx7_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx7_pinctrl_ops,
index 3288926..1f4fce4 100644 (file)
@@ -18,14 +18,6 @@ static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info1 = {
        .flags = ZERO_OFFSET_VALID | SHARE_MUX_CONF_REG | CFG_IBE_OBE,
 };
 
-static int imx7ulp_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx7ulp_pinctrl_match[] = {
        { .compatible = "fsl,imx7ulp-iomuxc-0", .data = (ulong)&imx7ulp_pinctrl_soc_info0 },
        { .compatible = "fsl,imx7ulp-iomuxc-1", .data = (ulong)&imx7ulp_pinctrl_soc_info1 },
@@ -40,7 +32,7 @@ U_BOOT_DRIVER(imx7ulp_pinctrl) = {
        .name = "imx7ulp-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx7ulp_pinctrl_match),
-       .probe = imx7ulp_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx7ulp_pinctrl_ops,
index 85e5e5f..40976a9 100644 (file)
@@ -15,14 +15,6 @@ static struct imx_pinctrl_soc_info imx8_pinctrl_soc_info = {
        .flags = IMX8_USE_SCU,
 };
 
-static int imx8_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx8_pinctrl_match[] = {
        { .compatible = "fsl,imx8qxp-iomuxc", .data = (ulong)&imx8_pinctrl_soc_info },
        { .compatible = "fsl,imx8qm-iomuxc", .data = (ulong)&imx8_pinctrl_soc_info },
@@ -37,7 +29,7 @@ U_BOOT_DRIVER(imx8_pinctrl) = {
        .name = "imx8_pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx8_pinctrl_match),
-       .probe = imx8_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx8_pinctrl_ops,
        .flags = DM_FLAG_PRE_RELOC,
index 661e08c..b1dabaa 100644 (file)
 
 static struct imx_pinctrl_soc_info imx8mq_pinctrl_soc_info __section(".data");
 
-static int imx8mq_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx8m_pinctrl_match[] = {
        { .compatible = "fsl,imx8mq-iomuxc", .data = (ulong)&imx8mq_pinctrl_soc_info },
        { .compatible = "fsl,imx8mm-iomuxc", .data = (ulong)&imx8mq_pinctrl_soc_info },
@@ -34,7 +26,7 @@ U_BOOT_DRIVER(imx8mq_pinctrl) = {
        .name = "imx8mq-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx8m_pinctrl_match),
-       .probe = imx8mq_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx8m_pinctrl_ops,
index 40901f3..e482ad5 100644 (file)
@@ -17,14 +17,6 @@ static struct imx_pinctrl_soc_info imx8ulp_pinctrl_soc_info1 = {
        .flags = ZERO_OFFSET_VALID | SHARE_MUX_CONF_REG | CFG_IBE_OBE,
 };
 
-static int imx8ulp_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx8ulp_pinctrl_match[] = {
        { .compatible = "fsl,imx8ulp-iomuxc0", .data = (ulong)&imx8ulp_pinctrl_soc_info0 },
        { .compatible = "fsl,imx8ulp-iomuxc1", .data = (ulong)&imx8ulp_pinctrl_soc_info1 },
@@ -39,7 +31,7 @@ U_BOOT_DRIVER(imx8ulp_pinctrl) = {
        .name = "imx8ulp-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx8ulp_pinctrl_match),
-       .probe = imx8ulp_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto = sizeof(struct imx_pinctrl_priv),
        .ops = &imx8ulp_pinctrl_ops,
index 4db224d..d5736e2 100644 (file)
@@ -12,14 +12,6 @@ static struct imx_pinctrl_soc_info imx93_pinctrl_soc_info __section(".data") = {
        .flags = ZERO_OFFSET_VALID,
 };
 
-static int imx93_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imx93_pinctrl_match[] = {
        { .compatible = "fsl,imx93-iomuxc", .data = (ulong)&imx93_pinctrl_soc_info },
        { .compatible = "fsl,imx91-iomuxc", .data = (ulong)&imx93_pinctrl_soc_info },
@@ -34,7 +26,7 @@ U_BOOT_DRIVER(imx93_pinctrl) = {
        .name = "imx93-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imx93_pinctrl_match),
-       .probe = imx93_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imx93_pinctrl_ops,
index 4383015..db523a9 100644 (file)
@@ -13,14 +13,6 @@ static struct imx_pinctrl_soc_info imxrt_pinctrl_soc_info = {
        .flags = ZERO_OFFSET_VALID,
 };
 
-static int imxrt_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id imxrt_pinctrl_match[] = {
        { .compatible = "fsl,imxrt-iomuxc",
          .data = (ulong)&imxrt_pinctrl_soc_info },
@@ -35,7 +27,7 @@ U_BOOT_DRIVER(imxrt_pinctrl) = {
        .name = "imxrt-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(imxrt_pinctrl_match),
-       .probe = imxrt_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &imxrt_pinctrl_ops,
index 0e17b8c..e56df6d 100644 (file)
@@ -13,14 +13,6 @@ static struct imx_pinctrl_soc_info vf610_pinctrl_soc_info = {
        .flags = SHARE_MUX_CONF_REG | ZERO_OFFSET_VALID,
 };
 
-static int vf610_pinctrl_probe(struct udevice *dev)
-{
-       struct imx_pinctrl_soc_info *info =
-               (struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
-
-       return imx_pinctrl_probe(dev, info);
-}
-
 static const struct udevice_id vf610_pinctrl_match[] = {
        { .compatible = "fsl,vf610-iomuxc",
          .data = (ulong)&vf610_pinctrl_soc_info },
@@ -35,7 +27,7 @@ U_BOOT_DRIVER(vf610_pinctrl) = {
        .name = "vf610-pinctrl",
        .id = UCLASS_PINCTRL,
        .of_match = of_match_ptr(vf610_pinctrl_match),
-       .probe = vf610_pinctrl_probe,
+       .probe = imx_pinctrl_probe,
        .remove = imx_pinctrl_remove,
        .priv_auto      = sizeof(struct imx_pinctrl_priv),
        .ops = &vf610_pinctrl_ops,