git.openpandora.org
/
pandora-u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e2be177
)
board: phytec: imx8m_som_detection: fix uninitialized pointer bug
author
Yannic Moog
<y.moog@phytec.de>
Wed, 20 Dec 2023 08:45:33 +0000
(09:45 +0100)
committer
Fabio Estevam
<festevam@denx.de>
Wed, 20 Dec 2023 18:04:46 +0000
(15:04 -0300)
Pointer in phytec_imx8m_detect was accessed without checking it first.
Fix this by moving the pointer check in front of any accesses.
Signed-off-by: Yannic Moog <y.moog@phytec.de>
board/phytec/common/imx8m_som_detection.c
patch
|
blob
|
history
diff --git
a/board/phytec/common/imx8m_som_detection.c
b/board/phytec/common/imx8m_som_detection.c
index
45f5767
..
a229eae
100644
(file)
--- a/
board/phytec/common/imx8m_som_detection.c
+++ b/
board/phytec/common/imx8m_som_detection.c
@@
-28,13
+28,13
@@
int __maybe_unused phytec_imx8m_detect(struct phytec_eeprom_data *data)
char *opt;
u8 som;
+ if (!data)
+ data = &eeprom_data;
+
/* We can not do the check for early API revisions */
if (data->api_rev < PHYTEC_API_REV2)
return -1;
- if (!data)
- data = &eeprom_data;
-
som = data->data.data_api2.som_no;
debug("%s: som id: %u\n", __func__, som);