pinctrl: qcom: sdm845: Limit check off by 1
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Thu, 7 Aug 2025 11:20:02 +0000 (12:20 +0100)
committerCasey Connolly <casey.connolly@linaro.org>
Wed, 13 Aug 2025 13:18:49 +0000 (15:18 +0200)
The driver specifies 154 pins so should have a maximum selector of 153
to ensure that the index into the array special_pins_names does not
overflow.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Link: https://lore.kernel.org/r/20250807-pinctrl_qcom-v1-2-42fac6707fd5@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
drivers/pinctrl/qcom/pinctrl-sdm845.c

index 3f55fc8..24b42e9 100644 (file)
@@ -72,7 +72,7 @@ static const char *sdm845_get_pin_name(struct udevice *dev,
                "sdc2_data",
        };
 
-       if (selector >= 150 && selector <= 154)
+       if (selector >= 150 && selector <= 153)
                snprintf(pin_name, MAX_PIN_NAME_LEN, special_pins_names[selector - 150]);
        else
                snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector);