mei: add a reference from the host client to the me client

Keep a pointer to associated me client in the host client object to
eliminate me client searches. Check if the me client is active in the
firmware by checking if its is linked on the me clients list
Add accessors for the me client properties from host client.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c
index d2cd53e..3c69616 100644 (file)
--- a/drivers/misc/mei/amthif.c
+++ b/drivers/misc/mei/amthif.c
@@ -59,28 +59,19 @@ void mei_amthif_reset_params(struct mei_device *dev)
  * mei_amthif_host_init - mei initialization amthif client.
  *
  * @dev: the device structure
+ * @me_cl: me client
  *
  * Return: 0 on success, <0 on failure.
  */
-int mei_amthif_host_init(struct mei_device *dev)
+int mei_amthif_host_init(struct mei_device *dev, struct mei_me_client *me_cl)
 {
        struct mei_cl *cl = &dev->iamthif_cl;
-       struct mei_me_client *me_cl;
        int ret;
 
        dev->iamthif_state = MEI_IAMTHIF_IDLE;
 
        mei_cl_init(cl, dev);
 
-       me_cl = mei_me_cl_by_uuid(dev, &mei_amthif_guid);
-       if (!me_cl) {
-               dev_info(dev->dev, "amthif: failed to find the client");
-               return -ENOTTY;
-       }
-
-       cl->me_client_id = me_cl->client_id;
-       cl->cl_uuid = me_cl->props.protocol_name;
-
        /* Assign iamthif_mtu to the value received from ME  */
 
        dev->iamthif_mtu = me_cl->props.max_msg_length;
@@ -90,15 +81,13 @@ int mei_amthif_host_init(struct mei_device *dev)
        ret = mei_cl_link(cl, MEI_IAMTHIF_HOST_CLIENT_ID);
        if (ret < 0) {
                dev_err(dev->dev, "amthif: failed cl_link %d\n", ret);
-               goto out;
+               return ret;
        }
 
-       ret = mei_cl_connect(cl, NULL);
+       ret = mei_cl_connect(cl, me_cl, NULL);
 
        dev->iamthif_state = MEI_IAMTHIF_IDLE;
 
-out:
-       mei_me_cl_put(me_cl);
        return ret;
 }
 

diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index 00b0cb2..1101d6e 100644 (file)
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -133,7 +133,13 @@ static struct bus_type mei_cl_bus_type = {
 
 static void mei_cl_dev_release(struct device *dev)
 {
-       kfree(to_mei_cl_device(dev));
+       struct mei_cl_device *device = to_mei_cl_device(dev);
+
+       if (!device)
+               return;
+
+       mei_me_cl_put(device->me_cl);
+       kfree(device);
 }
 
 static struct device_type mei_cl_device_type = {
@@ -141,33 +147,37 @@ static struct device_type mei_cl_device_type = {
 };
 
 struct mei_cl *mei_cl_bus_find_cl_by_uuid(struct mei_device *dev,
-                                               uuid_le uuid)
+                                        uuid_le uuid)
 {
        struct mei_cl *cl;
 
        list_for_each_entry(cl, &dev->device_list, device_link) {
-               if (!uuid_le_cmp(uuid, cl->cl_uuid))
+               if (cl->device && cl->device->me_cl &&
+                   !uuid_le_cmp(uuid, *mei_me_cl_uuid(cl->device->me_cl)))
                        return cl;
        }
 
        return NULL;
 }
+
 struct mei_cl_device *mei_cl_add_device(struct mei_device *dev,
-                                       uuid_le uuid, char *name,
+                                       struct mei_me_client *me_cl,
+                                       struct mei_cl *cl,
+                                       char *name,
                                        struct mei_cl_ops *ops)
 {
        struct mei_cl_device *device;
-       struct mei_cl *cl;
        int status;
 
-       cl = mei_cl_bus_find_cl_by_uuid(dev, uuid);
-       if (cl == NULL)
-               return NULL;
-
        device = kzalloc(sizeof(struct mei_cl_device), GFP_KERNEL);
        if (!device)
                return NULL;
 
+       device->me_cl = mei_me_cl_get(me_cl);
+       if (!device->me_cl) {
+               kfree(device);
+               return NULL;
+       }
        device->cl = cl;
        device->ops = ops;
 
@@ -180,6 +190,7 @@ struct mei_cl_device *mei_cl_add_device(struct mei_device *dev,
        status = device_register(&device->dev);
        if (status) {
                dev_err(dev->dev, "Failed to register MEI device\n");
+               mei_me_cl_put(device->me_cl);
                kfree(device);
                return NULL;
        }
@@ -228,7 +239,6 @@ static ssize_t ___mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length,
                        bool blocking)
 {
        struct mei_device *dev;
-       struct mei_me_client *me_cl = NULL;
        struct mei_cl_cb *cb = NULL;
        ssize_t rets;
 
@@ -244,13 +254,12 @@ static ssize_t ___mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length,
        }
 
        /* Check if we have an ME client device */
-       me_cl = mei_me_cl_by_uuid_id(dev, &cl->cl_uuid, cl->me_client_id);
-       if (!me_cl) {
+       if (!mei_me_cl_is_active(cl->me_cl)) {
                rets = -ENOTTY;
                goto out;
        }
 
-       if (length > me_cl->props.max_msg_length) {
+       if (length > mei_cl_mtu(cl)) {
                rets = -EFBIG;
                goto out;
        }
@@ -266,7 +275,6 @@ static ssize_t ___mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length,
        rets = mei_cl_write(cl, cb, blocking);
 
 out:
-       mei_me_cl_put(me_cl);
        mutex_unlock(&dev->device_lock);
        if (rets < 0)
                mei_io_cb_free(cb);
@@ -442,7 +450,7 @@ int mei_cl_enable_device(struct mei_cl_device *device)
                return -EBUSY;
        }
 
-       err = mei_cl_connect(cl, NULL);
+       err = mei_cl_connect(cl, device->me_cl, NULL);
        if (err < 0) {
                mutex_unlock(&dev->device_lock);
                dev_err(dev->dev, "Could not connect to the ME client");

diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index 3f8bb90..aa1d35a 100644 (file)
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -83,7 +83,7 @@ void mei_me_cl_put(struct mei_me_client *me_cl)
 }
 
 /**
- * __mei_me_cl_del  - delete me client form the list and decrease
+ * __mei_me_cl_del  - delete me client from the list and decrease
  *     reference counter
  *
  * @dev: mei device
@@ -96,10 +96,24 @@ static void __mei_me_cl_del(struct mei_device *dev, struct mei_me_client *me_cl)
        if (!me_cl)
                return;
 
-       list_del(&me_cl->list);
+       list_del_init(&me_cl->list);
        mei_me_cl_put(me_cl);
 }
 
+/**
+ * mei_me_cl_del - delete me client from the list and decrease
+ *     reference counter
+ *
+ * @dev: mei device
+ * @me_cl: me client
+ */
+void mei_me_cl_del(struct mei_device *dev, struct mei_me_client *me_cl)
+{
+       down_write(&dev->me_clients_rwsem);
+       __mei_me_cl_del(dev, me_cl);
+       up_write(&dev->me_clients_rwsem);
+}
+
 /**
  * mei_me_cl_add - add me client to the list
  *
@@ -317,7 +331,7 @@ static inline bool mei_cl_cmp_id(const struct mei_cl *cl1,
 {
        return cl1 && cl2 &&
                (cl1->host_client_id == cl2->host_client_id) &&
-               (cl1->me_client_id == cl2->me_client_id);
+               (mei_cl_me_id(cl1) == mei_cl_me_id(cl2));
 }
 
 /**
@@ -620,7 +634,7 @@ int mei_cl_link(struct mei_cl *cl, int id)
 }
 
 /**
- * mei_cl_unlink - remove me_cl from the list
+ * mei_cl_unlink - remove host client from the list
  *
  * @cl: host client
  *
@@ -668,17 +682,17 @@ void mei_host_client_init(struct work_struct *work)
 
        me_cl = mei_me_cl_by_uuid(dev, &mei_amthif_guid);
        if (me_cl)
-               mei_amthif_host_init(dev);
+               mei_amthif_host_init(dev, me_cl);
        mei_me_cl_put(me_cl);
 
        me_cl = mei_me_cl_by_uuid(dev, &mei_wd_guid);
        if (me_cl)
-               mei_wd_host_init(dev);
+               mei_wd_host_init(dev, me_cl);
        mei_me_cl_put(me_cl);
 
        me_cl = mei_me_cl_by_uuid(dev, &mei_nfc_guid);
        if (me_cl)
-               mei_nfc_host_init(dev);
+               mei_nfc_host_init(dev, me_cl);
        mei_me_cl_put(me_cl);
 
 
@@ -734,6 +748,9 @@ void mei_cl_set_disconnected(struct mei_cl *cl)
        mei_io_list_flush(&dev->ctrl_wr_list, cl);
        cl->mei_flow_ctrl_creds = 0;
        cl->timer_count = 0;
+
+       mei_me_cl_put(cl->me_cl);
+       cl->me_cl = NULL;
 }
 
 /*
@@ -890,7 +907,7 @@ static bool mei_cl_is_other_connecting(struct mei_cl *cl)
 
        list_for_each_entry(cb, &dev->ctrl_rd_list.list, list) {
                if (cb->fop_type == MEI_FOP_CONNECT &&
-                   cl->me_client_id == cb->cl->me_client_id)
+                   mei_cl_me_id(cl) == mei_cl_me_id(cb->cl))
                        return true;
        }
 
@@ -961,13 +978,15 @@ int mei_cl_irq_connect(struct mei_cl *cl, struct mei_cl_cb *cb,
  * mei_cl_connect - connect host client to the me one
  *
  * @cl: host client
+ * @me_cl: me client
  * @file: pointer to file structure
  *
  * Locking: called under "dev->device_lock" lock
  *
  * Return: 0 on success, <0 on failure.
  */
-int mei_cl_connect(struct mei_cl *cl, struct file *file)
+int mei_cl_connect(struct mei_cl *cl, struct mei_me_client *me_cl,
+                  struct file *file)
 {
        struct mei_device *dev;
        struct mei_cl_cb *cb;
@@ -990,6 +1009,12 @@ int mei_cl_connect(struct mei_cl *cl, struct file *file)
        if (rets)
                goto out;
 
+       cl->me_cl = mei_me_cl_get(me_cl);
+       if (!cl->me_cl) {
+               rets = -ENODEV;
+               goto out;
+       }
+
        cl->state = MEI_FILE_CONNECTING;
        list_add_tail(&cb->list, &dev->ctrl_wr_list.list);
 
@@ -1064,36 +1089,20 @@ err:
  * @cl: private data of the file object
  *
  * Return: 1 if mei_flow_ctrl_creds >0, 0 - otherwise.
- *     -ENOENT if mei_cl is not present
- *     -EINVAL if single_recv_buf == 0
  */
 int mei_cl_flow_ctrl_creds(struct mei_cl *cl)
 {
-       struct mei_device *dev;
-       struct mei_me_client *me_cl;
-       int rets = 0;
-
-       if (WARN_ON(!cl || !cl->dev))
+       if (WARN_ON(!cl || !cl->me_cl))
                return -EINVAL;
 
-       dev = cl->dev;
-
        if (cl->mei_flow_ctrl_creds > 0)
                return 1;
 
-       me_cl = mei_me_cl_by_uuid_id(dev, &cl->cl_uuid, cl->me_client_id);
-       if (!me_cl) {
-               cl_err(dev, cl, "no such me client %d\n", cl->me_client_id);
-               return -ENOENT;
+       if (mei_cl_is_single_recv_buf(cl)) {
+               if (cl->me_cl->mei_flow_ctrl_creds > 0)
+                       return 1;
        }
-
-       if (me_cl->mei_flow_ctrl_creds > 0) {
-               rets = 1;
-               if (WARN_ON(me_cl->props.single_recv_buf == 0))
-                       rets = -EINVAL;
-       }
-       mei_me_cl_put(me_cl);
-       return rets;
+       return 0;
 }
 
 /**
@@ -1103,43 +1112,23 @@ int mei_cl_flow_ctrl_creds(struct mei_cl *cl)
  *
  * Return:
  *     0 on success
- *     -ENOENT when me client is not found
  *     -EINVAL when ctrl credits are <= 0
  */
 int mei_cl_flow_ctrl_reduce(struct mei_cl *cl)
 {
-       struct mei_device *dev;
-       struct mei_me_client *me_cl;
-       int rets;
-
-       if (WARN_ON(!cl || !cl->dev))
+       if (WARN_ON(!cl || !cl->me_cl))
                return -EINVAL;
 
-       dev = cl->dev;
-
-       me_cl = mei_me_cl_by_uuid_id(dev, &cl->cl_uuid, cl->me_client_id);
-       if (!me_cl) {
-               cl_err(dev, cl, "no such me client %d\n", cl->me_client_id);
-               return -ENOENT;
-       }
-
-       if (me_cl->props.single_recv_buf) {
-               if (WARN_ON(me_cl->mei_flow_ctrl_creds <= 0)) {
-                       rets = -EINVAL;
-                       goto out;
-               }
-               me_cl->mei_flow_ctrl_creds--;
+       if (mei_cl_is_single_recv_buf(cl)) {
+               if (WARN_ON(cl->me_cl->mei_flow_ctrl_creds <= 0))
+                       return -EINVAL;
+               cl->me_cl->mei_flow_ctrl_creds--;
        } else {
-               if (WARN_ON(cl->mei_flow_ctrl_creds <= 0)) {
-                       rets = -EINVAL;
-                       goto out;
-               }
+               if (WARN_ON(cl->mei_flow_ctrl_creds <= 0))
+                       return -EINVAL;
                cl->mei_flow_ctrl_creds--;
        }
-       rets = 0;
-out:
-       mei_me_cl_put(me_cl);
-       return rets;
+       return 0;
 }
 
 /**
@@ -1155,7 +1144,6 @@ int mei_cl_read_start(struct mei_cl *cl, size_t length, struct file *fp)
 {
        struct mei_device *dev;
        struct mei_cl_cb *cb;
-       struct mei_me_client *me_cl;
        int rets;
 
        if (WARN_ON(!cl || !cl->dev))
@@ -1170,14 +1158,12 @@ int mei_cl_read_start(struct mei_cl *cl, size_t length, struct file *fp)
        if (!list_empty(&cl->rd_pending))
                return -EBUSY;
 
-       me_cl = mei_me_cl_by_uuid_id(dev, &cl->cl_uuid, cl->me_client_id);
-       if (!me_cl) {
-               cl_err(dev, cl, "no such me client %d\n", cl->me_client_id);
+       if (!mei_me_cl_is_active(cl->me_cl)) {
+               cl_err(dev, cl, "no such me client\n");
                return  -ENOTTY;
        }
        /* always allocate at least client max message */
-       length = max_t(size_t, length, me_cl->props.max_msg_length);
-       mei_me_cl_put(me_cl);
+       length = max_t(size_t, length, mei_cl_mtu(cl));
 
        rets = pm_runtime_get(dev->dev);
        if (rets < 0 && rets != -EINPROGRESS) {
@@ -1254,7 +1240,7 @@ int mei_cl_irq_write(struct mei_cl *cl, struct mei_cl_cb *cb,
        msg_slots = mei_data2slots(len);
 
        mei_hdr.host_addr = cl->host_client_id;
-       mei_hdr.me_addr = cl->me_client_id;
+       mei_hdr.me_addr = mei_cl_me_id(cl);
        mei_hdr.reserved = 0;
        mei_hdr.internal = cb->internal;
 
@@ -1338,7 +1324,7 @@ int mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, bool blocking)
        cl->writing_state = MEI_IDLE;
 
        mei_hdr.host_addr = cl->host_client_id;
-       mei_hdr.me_addr = cl->me_client_id;
+       mei_hdr.me_addr = mei_cl_me_id(cl);
        mei_hdr.reserved = 0;
        mei_hdr.msg_complete = 0;
        mei_hdr.internal = cb->internal;

diff --git a/drivers/misc/mei/client.h b/drivers/misc/mei/client.h
index 181aed9..0762650 100644 (file)
--- a/drivers/misc/mei/client.h
+++ b/drivers/misc/mei/client.h
@@ -44,6 +44,30 @@ void mei_me_cl_rm_by_uuid_id(struct mei_device *dev,
                             const uuid_le *uuid, u8 id);
 void mei_me_cl_rm_all(struct mei_device *dev);
 
+/**
+ * mei_me_cl_is_active - check whether me client is active in the fw
+ *
+ * @me_cl: me client
+ *
+ * Return: true if the me client is active in the firmware
+ */
+static inline bool mei_me_cl_is_active(const struct mei_me_client *me_cl)
+{
+       return !list_empty_careful(&me_cl->list);
+}
+
+/**
+ * mei_me_cl_uuid - return me client protocol name (uuid)
+ *
+ * @me_cl: me client
+ *
+ * Return: me client protocol name
+ */
+static inline const uuid_le *mei_me_cl_uuid(const struct mei_me_client *me_cl)
+{
+       return &me_cl->props.protocol_name;
+}
+
 /*
  * MEI IO Functions
  */
@@ -94,20 +118,82 @@ int mei_cl_flow_ctrl_reduce(struct mei_cl *cl);
 /**
  * mei_cl_is_connected - host client is connected
  *
- * @cl: host clinet
+ * @cl: host client
  *
- * Return: true if the host clinet is connected
+ * Return: true if the host client is connected
  */
 static inline bool mei_cl_is_connected(struct mei_cl *cl)
 {
        return  cl->state == MEI_FILE_CONNECTED;
 }
 
+/**
+ * mei_cl_me_id - me client id
+ *
+ * @cl: host client
+ *
+ * Return: me client id or 0 if client is not connected
+ */
+static inline u8 mei_cl_me_id(const struct mei_cl *cl)
+{
+       return cl->me_cl ? cl->me_cl->client_id : 0;
+}
+
+/**
+ * mei_cl_mtu - maximal message that client can send and receive
+ *
+ * @cl: host client
+ *
+ * Return: mtu
+ */
+static inline size_t mei_cl_mtu(const struct mei_cl *cl)
+{
+       return cl->me_cl->props.max_msg_length;
+}
+
+/**
+ * mei_cl_is_fixed_address - check whether the me client uses fixed address
+ *
+ * @cl: host client
+ *
+ * Return: true if the client is connected and it has fixed me address
+ */
+static inline bool mei_cl_is_fixed_address(const struct mei_cl *cl)
+{
+       return cl->me_cl && cl->me_cl->props.fixed_address;
+}
+
+/**
+ * mei_cl_is_single_recv_buf- check whether the me client
+ *       uses single receiving buffer
+ *
+ * @cl: host client
+ *
+ * Return: true if single_recv_buf == 1; 0 otherwise
+ */
+static inline bool mei_cl_is_single_recv_buf(const struct mei_cl *cl)
+{
+       return cl->me_cl->props.single_recv_buf;
+}
+
+/**
+ * mei_cl_uuid -  client's uuid
+ *
+ * @cl: host client
+ *
+ * Return: return uuid of connected me client
+ */
+static inline const uuid_le *mei_cl_uuid(const struct mei_cl *cl)
+{
+       return mei_me_cl_uuid(cl->me_cl);
+}
+
 int mei_cl_disconnect(struct mei_cl *cl);
 void mei_cl_set_disconnected(struct mei_cl *cl);
 int mei_cl_irq_disconnect(struct mei_cl *cl, struct mei_cl_cb *cb,
                          struct mei_cl_cb *cmpl_list);
-int mei_cl_connect(struct mei_cl *cl, struct file *file);
+int mei_cl_connect(struct mei_cl *cl, struct mei_me_client *me_cl,
+                  struct file *file);
 int mei_cl_irq_connect(struct mei_cl *cl, struct mei_cl_cb *cb,
                              struct mei_cl_cb *cmpl_list);
 int mei_cl_read_start(struct mei_cl *cl, size_t length, struct file *fp);
@@ -121,14 +207,12 @@ void mei_cl_complete(struct mei_cl *cl, struct mei_cl_cb *cb);
 
 void mei_host_client_init(struct work_struct *work);
 
-
-
 void mei_cl_all_disconnect(struct mei_device *dev);
 void mei_cl_all_wakeup(struct mei_device *dev);
 void mei_cl_all_write_clear(struct mei_device *dev);
 
 #define MEI_CL_FMT "cl:host=%02d me=%02d "
-#define MEI_CL_PRM(cl) (cl)->host_client_id, (cl)->me_client_id
+#define MEI_CL_PRM(cl) (cl)->host_client_id, mei_cl_me_id(cl)
 
 #define cl_dbg(dev, cl, format, arg...) \
        dev_dbg((dev)->dev, MEI_CL_FMT format, MEI_CL_PRM(cl), ##arg)

diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
index d9cd7e6..3f6d855 100644 (file)
--- a/drivers/misc/mei/debugfs.c
+++ b/drivers/misc/mei/debugfs.c
@@ -116,7 +116,7 @@ static ssize_t mei_dbgfs_read_active(struct file *fp, char __user *ubuf,
 
                pos += scnprintf(buf + pos, bufsz - pos,
                        "%2d|%2d|%4d|%5d|%2d|%2d|\n",
-                       i, cl->me_client_id, cl->host_client_id, cl->state,
+                       i, mei_cl_me_id(cl), cl->host_client_id, cl->state,
                        !list_empty(&cl->rd_completed), cl->writing_state);
                i++;
        }

diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c
index 410e029..f620824 100644 (file)
--- a/drivers/misc/mei/hbm.c
+++ b/drivers/misc/mei/hbm.c
@@ -151,7 +151,7 @@ void mei_hbm_cl_hdr(struct mei_cl *cl, u8 hbm_cmd, void *buf, size_t len)
 
        cmd->hbm_cmd = hbm_cmd;
        cmd->host_addr = cl->host_client_id;
-       cmd->me_addr = cl->me_client_id;
+       cmd->me_addr = mei_cl_me_id(cl);
 }
 
 /**
@@ -189,7 +189,7 @@ static inline
 bool mei_hbm_cl_addr_equal(struct mei_cl *cl, struct mei_hbm_cl_cmd *cmd)
 {
        return cl->host_client_id == cmd->host_addr &&
-               cl->me_client_id == cmd->me_addr;
+               mei_cl_me_id(cl) == cmd->me_addr;
 }
 
 /**

diff --cc drivers/misc/mei/interrupt.c
Simple merge

diff --cc drivers/misc/mei/main.c
Simple merge

diff --cc drivers/misc/mei/mei_dev.h
Simple merge

diff --cc drivers/misc/mei/nfc.c
Simple merge

diff --cc drivers/misc/mei/wd.c
Simple merge