classes/insane.bbclass: Make the .so-check check for symlinks (merge poky r1258...
authorHolger Freyther <zecke@selfish.org>
Mon, 19 Feb 2007 14:56:20 +0000 (14:56 +0000)
committerHolger Freyther <zecke@selfish.org>
Mon, 19 Feb 2007 14:56:20 +0000 (14:56 +0000)
    The .so check now looks for symlinks ending with .so. These are a typical
    trait of -dev packages and kills a lot of false positives.
    This was authored by ross and was taken from the poky svn repository.

classes/insane.bbclass

index 8a16922..ad95603 100644 (file)
@@ -212,9 +212,9 @@ def package_qa_check_devdbg(path, name,d):
     sane = True
 
     if not "-dev" in name:
-        if path[-3:] == ".so":
+        if path[-3:] == ".so" and os.path.islink(path):
             package_qa_write_error( 0, name, path, d )
-            bb.error("QA Issue: non dev package contains .so: %s path '%s'" % (name, package_qa_clean_path(path,d)))
+            bb.error("QA Issue: non -dev package %s contains symlink .so: %s path '%s'" % (name, package_qa_clean_path(path,d)))
             if package_qa_make_fatal_error( 0, name, path, d ):
                 sane = False