caam: Fix crash in case caam_jr_probe failed
authorYe Li <ye.li@nxp.com>
Wed, 11 May 2022 08:26:20 +0000 (13:56 +0530)
committerStefano Babic <sbabic@denx.de>
Fri, 20 May 2022 10:36:47 +0000 (12:36 +0200)
If probing caam_jr returns failure, the variable "dev" will not be
initialized, so we can't use dev->name for the error print.
Otherwise it will cause crash.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>
arch/arm/cpu/armv7/ls102xa/cpu.c
arch/arm/cpu/armv8/fsl-layerscape/cpu.c
arch/arm/mach-imx/imx8/cpu.c
arch/arm/mach-imx/imx8m/soc.c
arch/arm/mach-imx/mx6/soc.c
arch/arm/mach-imx/mx7/soc.c
arch/arm/mach-imx/mx7ulp/soc.c
arch/powerpc/cpu/mpc85xx/cpu_init.c
board/freescale/imx8mm_evk/spl.c
board/freescale/imx8mn_evk/spl.c
board/freescale/imx8mp_evk/spl.c

index 9fe1cd9..0b3e3b2 100644 (file)
@@ -409,7 +409,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
 
        return 0;
index a71ee63..253008a 100644 (file)
@@ -1648,7 +1648,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
        serdes_misc_init();
 
index 0858ea5..936c8f8 100644 (file)
@@ -100,7 +100,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
 
        return 0;
index d261a07..5933535 100644 (file)
@@ -1408,7 +1408,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
 
        return 0;
index 2434bcf..67bd991 100644 (file)
@@ -744,7 +744,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
        setup_serial_number();
        return 0;
index dc9ac31..c672be5 100644 (file)
@@ -361,7 +361,7 @@ int arch_misc_init(void)
                int ret;
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
 
        return 0;
index 08bdc0c..217b7c4 100644 (file)
@@ -93,7 +93,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
 
        return 0;
index 16981de..5fa4234 100644 (file)
@@ -950,7 +950,7 @@ int arch_misc_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
 
        return 0;
index ae2fb73..4d96324 100644 (file)
@@ -57,7 +57,7 @@ void spl_board_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
        puts("Normal Boot\n");
 }
index 3d9aa56..14cb513 100644 (file)
@@ -52,7 +52,7 @@ void spl_board_init(void)
        if (IS_ENABLED(CONFIG_FSL_CAAM)) {
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
        puts("Normal Boot\n");
 
index a273214..719b1f6 100644 (file)
@@ -43,7 +43,7 @@ void spl_board_init(void)
 
                ret = uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(caam_jr), &dev);
                if (ret)
-                       printf("Failed to initialize %s: %d\n", dev->name, ret);
+                       printf("Failed to initialize caam_jr: %d\n", ret);
        }
        /*
         * Set GIC clock to 500Mhz for OD VDD_SOC. Kernel driver does