power: pmic: Correct debug/error output

There is a newline missing from quite a few printf() strings in these pmic
files. Fix them.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Lukasz Majewski <lukma@denx.de>

diff --git a/drivers/power/pmic/act8846.c b/drivers/power/pmic/act8846.c
index b0c759c..186fa90 100644 (file)
--- a/drivers/power/pmic/act8846.c
+++ b/drivers/power/pmic/act8846.c
@@ -50,7 +50,7 @@ static int act8846_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }

diff --git a/drivers/power/pmic/as3722.c b/drivers/power/pmic/as3722.c
index 63df613..54adcbf 100644 (file)
--- a/drivers/power/pmic/as3722.c
+++ b/drivers/power/pmic/as3722.c
@@ -45,14 +45,14 @@ static int as3722_read_id(struct udevice *dev, uint *idp, uint *revisionp)
 
        ret = pmic_reg_read(dev, AS3722_ASIC_ID1);
        if (ret < 0) {
-               pr_err("failed to read ID1 register: %d", ret);
+               pr_err("failed to read ID1 register: %d\n", ret);
                return ret;
        }
        *idp = ret;
 
        ret = pmic_reg_read(dev, AS3722_ASIC_ID2);
        if (ret < 0) {
-               pr_err("failed to read ID2 register: %d", ret);
+               pr_err("failed to read ID2 register: %d\n", ret);
                return ret;
        }
        *revisionp = ret;
@@ -70,7 +70,7 @@ int as3722_sd_set_voltage(struct udevice *dev, unsigned int sd, u8 value)
 
        ret = pmic_reg_write(dev, AS3722_SD_VOLTAGE(sd), value);
        if (ret < 0) {
-               pr_err("failed to write SD%u voltage register: %d", sd, ret);
+               pr_err("failed to write SD%u voltage register: %d\n", sd, ret);
                return ret;
        }
 
@@ -86,8 +86,8 @@ int as3722_ldo_set_voltage(struct udevice *dev, unsigned int ldo, u8 value)
 
        ret = pmic_reg_write(dev, AS3722_LDO_VOLTAGE(ldo), value);
        if (ret < 0) {
-               pr_err("failed to write LDO%u voltage register: %d", ldo,
-                     ret);
+               pr_err("failed to write LDO%u voltage register: %d\n", ldo,
+                      ret);
                return ret;
        }
 
@@ -101,12 +101,12 @@ static int as3722_probe(struct udevice *dev)
 
        ret = as3722_read_id(dev, &id, &revision);
        if (ret < 0) {
-               pr_err("failed to read ID: %d", ret);
+               pr_err("failed to read ID: %d\n", ret);
                return ret;
        }
 
        if (id != AS3722_DEVICE_ID) {
-               pr_err("unknown device");
+               pr_err("unknown device\n");
                return -ENOENT;
        }
 

diff --git a/drivers/power/pmic/as3722_gpio.c b/drivers/power/pmic/as3722_gpio.c
index 36f4fbf..96943bc 100644 (file)
--- a/drivers/power/pmic/as3722_gpio.c
+++ b/drivers/power/pmic/as3722_gpio.c
@@ -25,7 +25,7 @@ int as3722_gpio_configure(struct udevice *pmic, unsigned int gpio,
 
        err = pmic_reg_write(pmic, AS3722_GPIO_CONTROL(gpio), value);
        if (err) {
-               pr_err("failed to configure GPIO#%u: %d", gpio, err);
+               pr_err("failed to configure GPIO#%u: %d\n", gpio, err);
                return err;
        }
 
@@ -45,7 +45,7 @@ static int as3722_gpio_set_value(struct udevice *dev, unsigned int gpio,
 
        err = pmic_reg_read(pmic, AS3722_GPIO_SIGNAL_OUT);
        if (err < 0) {
-               pr_err("failed to read GPIO signal out register: %d", err);
+               pr_err("failed to read GPIO signal out register: %d\n", err);
                return err;
        }
        value = err;
@@ -60,7 +60,7 @@ static int as3722_gpio_set_value(struct udevice *dev, unsigned int gpio,
 
        err = pmic_reg_write(pmic, AS3722_GPIO_SIGNAL_OUT, value);
        if (err) {
-               pr_err("failed to set GPIO#%u %s: %d", gpio, l, err);
+               pr_err("failed to set GPIO#%u %s: %d\n", gpio, l, err);
                return err;
        }
 
@@ -83,13 +83,14 @@ int as3722_gpio_direction_output(struct udevice *dev, unsigned int gpio,
 
        err = pmic_reg_write(pmic, AS3722_GPIO_CONTROL(gpio), value);
        if (err) {
-               pr_err("failed to configure GPIO#%u as output: %d", gpio, err);
+               pr_err("failed to configure GPIO#%u as output: %d\n", gpio,
+                      err);
                return err;
        }
 
        err = as3722_gpio_set_value(pmic, gpio, value);
        if (err < 0) {
-               pr_err("failed to set GPIO#%u high: %d", gpio, err);
+               pr_err("failed to set GPIO#%u high: %d\n", gpio, err);
                return err;
        }
 

diff --git a/drivers/power/pmic/lp873x.c b/drivers/power/pmic/lp873x.c
index 432ad4c..4ae4043 100644 (file)
--- a/drivers/power/pmic/lp873x.c
+++ b/drivers/power/pmic/lp873x.c
@@ -24,7 +24,7 @@ static int lp873x_write(struct udevice *dev, uint reg, const uint8_t *buff,
                          int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -34,7 +34,7 @@ static int lp873x_write(struct udevice *dev, uint reg, const uint8_t *buff,
 static int lp873x_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 {
        if (dm_i2c_read(dev, reg, buff, len)) {
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -48,7 +48,7 @@ static int lp873x_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }

diff --git a/drivers/power/pmic/lp87565.c b/drivers/power/pmic/lp87565.c
index 450dbb8..3e5fc60 100644 (file)
--- a/drivers/power/pmic/lp87565.c
+++ b/drivers/power/pmic/lp87565.c
@@ -26,7 +26,7 @@ static int lp87565_write(struct udevice *dev, uint reg, const uint8_t *buff,
 
        ret = dm_i2c_write(dev, reg, buff, len);
        if (ret)
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -37,7 +37,7 @@ static int lp87565_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret)
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -49,7 +49,7 @@ static int lp87565_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }

diff --git a/drivers/power/pmic/max77686.c b/drivers/power/pmic/max77686.c
index 834713a..8e3a8cf 100644 (file)
--- a/drivers/power/pmic/max77686.c
+++ b/drivers/power/pmic/max77686.c
@@ -28,7 +28,7 @@ static int max77686_write(struct udevice *dev, uint reg, const uint8_t *buff,
                          int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -38,7 +38,7 @@ static int max77686_write(struct udevice *dev, uint reg, const uint8_t *buff,
 static int max77686_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 {
        if (dm_i2c_read(dev, reg, buff, len)) {
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -52,8 +52,8 @@ static int max77686_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "voltage-regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
-                                                            dev->name);
+               debug("%s: %s regulators subnode not found!\n", __func__,
+                     dev->name);
                return -ENXIO;
        }
 

diff --git a/drivers/power/pmic/max8997.c b/drivers/power/pmic/max8997.c
index 0dcdbad..dbae155 100644 (file)
--- a/drivers/power/pmic/max8997.c
+++ b/drivers/power/pmic/max8997.c
@@ -23,7 +23,7 @@ static int max8997_write(struct udevice *dev, uint reg, const uint8_t *buff,
 
        ret = dm_i2c_write(dev, reg, buff, len);
        if (ret)
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -34,7 +34,7 @@ static int max8997_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret)
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }

diff --git a/drivers/power/pmic/max8998.c b/drivers/power/pmic/max8998.c
index f571add..f58d9f2 100644 (file)
--- a/drivers/power/pmic/max8998.c
+++ b/drivers/power/pmic/max8998.c
@@ -23,7 +23,7 @@ static int max8998_write(struct udevice *dev, uint reg, const uint8_t *buff,
 
        ret = dm_i2c_write(dev, reg, buff, len);
        if (ret)
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -34,7 +34,7 @@ static int max8998_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret)
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }

diff --git a/drivers/power/pmic/mc34708.c b/drivers/power/pmic/mc34708.c
index 2b2fc72..66253a4 100644 (file)
--- a/drivers/power/pmic/mc34708.c
+++ b/drivers/power/pmic/mc34708.c
@@ -38,7 +38,7 @@ static int mc34708_write(struct udevice *dev, uint reg, const u8 *buff,
 
        ret = dm_i2c_write(dev, reg, buf, len);
        if (ret)
-               printf("write error to device: %p register: %#x!", dev, reg);
+               printf("write error to device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -53,7 +53,7 @@ static int mc34708_read(struct udevice *dev, uint reg, u8 *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buf, len);
        if (ret)
-               printf("read error from device: %p register: %#x!", dev, reg);
+               printf("read error from device: %p register: %#x!\n", dev, reg);
 
        buff[0] = buf[2];
        buff[1] = buf[1];

diff --git a/drivers/power/pmic/palmas.c b/drivers/power/pmic/palmas.c
index 250a5d3..36be119 100644 (file)
--- a/drivers/power/pmic/palmas.c
+++ b/drivers/power/pmic/palmas.c
@@ -24,7 +24,7 @@ static int palmas_write(struct udevice *dev, uint reg, const uint8_t *buff,
                          int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -34,7 +34,7 @@ static int palmas_write(struct udevice *dev, uint reg, const uint8_t *buff,
 static int palmas_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 {
        if (dm_i2c_read(dev, reg, buff, len)) {
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -60,14 +60,14 @@ static int palmas_bind(struct udevice *dev)
        }
 
        if (!ofnode_valid(pmic_node)) {
-               debug("%s: %s pmic subnode not found!", __func__, dev->name);
+               debug("%s: %s pmic subnode not found!\n", __func__, dev->name);
                return -ENXIO;
        }
 
        regulators_node = ofnode_find_subnode(pmic_node, "regulators");
 
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s reg subnode not found!", __func__, dev->name);
+               debug("%s: %s reg subnode not found!\n", __func__, dev->name);
                return -ENXIO;
        }
 

diff --git a/drivers/power/pmic/pfuze100.c b/drivers/power/pmic/pfuze100.c
index 8a5a899..6cf5f35 100644 (file)
--- a/drivers/power/pmic/pfuze100.c
+++ b/drivers/power/pmic/pfuze100.c
@@ -31,7 +31,7 @@ static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t *buff,
                          int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -41,7 +41,7 @@ static int pfuze100_write(struct udevice *dev, uint reg, const uint8_t *buff,
 static int pfuze100_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 {
        if (dm_i2c_read(dev, reg, buff, len)) {
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -55,7 +55,7 @@ static int pfuze100_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }

diff --git a/drivers/power/pmic/rk8xx.c b/drivers/power/pmic/rk8xx.c
index c60dfff..25c339a 100644 (file)
--- a/drivers/power/pmic/rk8xx.c
+++ b/drivers/power/pmic/rk8xx.c
@@ -29,7 +29,7 @@ static int rk8xx_write(struct udevice *dev, uint reg, const uint8_t *buff,
 
        ret = dm_i2c_write(dev, reg, buff, len);
        if (ret) {
-               debug("write error to device: %p register: %#x!", dev, reg);
+               debug("write error to device: %p register: %#x!\n", dev, reg);
                return ret;
        }
 
@@ -42,7 +42,7 @@ static int rk8xx_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret) {
-               debug("read error from device: %p register: %#x!", dev, reg);
+               debug("read error from device: %p register: %#x!\n", dev, reg);
                return ret;
        }
 
@@ -57,7 +57,7 @@ static int rk8xx_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }

diff --git a/drivers/power/pmic/rn5t567.c b/drivers/power/pmic/rn5t567.c
index c3be3fe..f238396 100644 (file)
--- a/drivers/power/pmic/rn5t567.c
+++ b/drivers/power/pmic/rn5t567.c
@@ -24,7 +24,7 @@ static int rn5t567_write(struct udevice *dev, uint reg, const uint8_t *buff,
 
        ret = dm_i2c_write(dev, reg, buff, len);
        if (ret) {
-               debug("write error to device: %p register: %#x!", dev, reg);
+               debug("write error to device: %p register: %#x!\n", dev, reg);
                return ret;
        }
 
@@ -37,7 +37,7 @@ static int rn5t567_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret) {
-               debug("read error from device: %p register: %#x!", dev, reg);
+               debug("read error from device: %p register: %#x!\n", dev, reg);
                return ret;
        }
 

diff --git a/drivers/power/pmic/s2mps11.c b/drivers/power/pmic/s2mps11.c
index e45d4bc..f2aab6c 100644 (file)
--- a/drivers/power/pmic/s2mps11.c
+++ b/drivers/power/pmic/s2mps11.c
@@ -30,7 +30,7 @@ static int s2mps11_write(struct udevice *dev, uint reg, const uint8_t *buff,
 
        ret = dm_i2c_write(dev, reg, buff, len);
        if (ret)
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -41,7 +41,7 @@ static int s2mps11_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret)
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
 
        return ret;
 }
@@ -53,8 +53,8 @@ static int s2mps11_probe(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "voltage-regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
-                                                            dev->name);
+               debug("%s: %s regulators subnode not found!\n", __func__,
+                     dev->name);
                return -ENXIO;
        }
 

diff --git a/drivers/power/pmic/s5m8767.c b/drivers/power/pmic/s5m8767.c
index 54e44ce..b5ddd49 100644 (file)
--- a/drivers/power/pmic/s5m8767.c
+++ b/drivers/power/pmic/s5m8767.c
@@ -27,7 +27,7 @@ static int s5m8767_write(struct udevice *dev, uint reg, const uint8_t *buff,
                          int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -37,7 +37,7 @@ static int s5m8767_write(struct udevice *dev, uint reg, const uint8_t *buff,
 static int s5m8767_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 {
        if (dm_i2c_read(dev, reg, buff, len)) {
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -56,7 +56,7 @@ static int s5m8767_bind(struct udevice *dev)
 
        node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }

diff --git a/drivers/power/pmic/sandbox.c b/drivers/power/pmic/sandbox.c
index 64e2f27..d787091 100644 (file)
--- a/drivers/power/pmic/sandbox.c
+++ b/drivers/power/pmic/sandbox.c
@@ -28,7 +28,7 @@ static int sandbox_pmic_write(struct udevice *dev, uint reg,
                              const uint8_t *buff, int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -39,7 +39,7 @@ static int sandbox_pmic_read(struct udevice *dev, uint reg,
                             uint8_t *buff, int len)
 {
        if (dm_i2c_read(dev, reg, buff, len)) {
-               pr_err("read error from device: %p register: %#x!", dev, reg);
+               pr_err("read error from device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 

diff --git a/drivers/power/pmic/stpmu1.c b/drivers/power/pmic/stpmu1.c
index 82351b6..47af012 100644 (file)
--- a/drivers/power/pmic/stpmu1.c
+++ b/drivers/power/pmic/stpmu1.c
@@ -61,7 +61,7 @@ static int stpmu1_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               dev_dbg(dev, "regulators subnode not found!");
+               dev_dbg(dev, "regulators subnode not found!\n");
                return -ENXIO;
        }
        dev_dbg(dev, "found regulators subnode\n");

diff --git a/drivers/power/pmic/tps65090.c b/drivers/power/pmic/tps65090.c
index 1d3bf00..5b1d19f 100644 (file)
--- a/drivers/power/pmic/tps65090.c
+++ b/drivers/power/pmic/tps65090.c
@@ -26,7 +26,7 @@ static int tps65090_write(struct udevice *dev, uint reg, const uint8_t *buff,
                          int len)
 {
        if (dm_i2c_write(dev, reg, buff, len)) {
-               pr_err("write error to device: %p register: %#x!", dev, reg);
+               pr_err("write error to device: %p register: %#x!\n", dev, reg);
                return -EIO;
        }
 
@@ -39,8 +39,8 @@ static int tps65090_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
 
        ret = dm_i2c_read(dev, reg, buff, len);
        if (ret) {
-               pr_err("read error %d from device: %p register: %#x!", ret, dev,
-                     reg);
+               pr_err("read error %d from device: %p register: %#x!\n", ret,
+                      dev, reg);
                return -EIO;
        }
 
@@ -54,7 +54,7 @@ static int tps65090_bind(struct udevice *dev)
 
        regulators_node = dev_read_subnode(dev, "regulators");
        if (!ofnode_valid(regulators_node)) {
-               debug("%s: %s regulators subnode not found!", __func__,
+               debug("%s: %s regulators subnode not found!\n", __func__,
                      dev->name);
                return -ENXIO;
        }