mtd: nand: raw: atmel: remove unnecessary return value
authorMarcus Folkesson <marcus.folkesson@gmail.com>
Fri, 9 Aug 2024 12:15:43 +0000 (14:15 +0200)
committerTom Rini <trini@konsulko.com>
Tue, 17 Dec 2024 19:17:41 +0000 (13:17 -0600)
The condition 'ret' is always true as it is never set to other than
-EIO.

Remove 'ret' and the condition for copy.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Michael Trimarchi <micheal@amarulasolutions.com>
drivers/mtd/nand/raw/atmel/nand-controller.c

index 25f187a..56fbd64 100644 (file)
@@ -568,12 +568,9 @@ static void atmel_nfc_copy_to_sram(struct nand_chip *chip, const u8 *buf,
        struct mtd_info *mtd = nand_to_mtd(chip);
        struct atmel_nand *nand = to_atmel_nand(chip);
        struct atmel_hsmc_nand_controller *nc;
-       int ret = -EIO;
 
        nc = to_hsmc_nand_controller(nand->controller);
-
-       if (ret)
-               memcpy_toio(nc->sram.virt, buf, mtd->writesize);
+       memcpy_toio(nc->sram.virt, buf, mtd->writesize);
 
        if (oob_required)
                memcpy_toio(nc->sram.virt + mtd->writesize, chip->oob_poi,
@@ -586,12 +583,9 @@ static void atmel_nfc_copy_from_sram(struct nand_chip *chip, u8 *buf,
        struct mtd_info *mtd = nand_to_mtd(chip);
        struct atmel_nand *nand = to_atmel_nand(chip);
        struct atmel_hsmc_nand_controller *nc;
-       int ret = -EIO;
 
        nc = to_hsmc_nand_controller(nand->controller);
-
-       if (ret)
-               memcpy_fromio(buf, nc->sram.virt, mtd->writesize);
+       memcpy_fromio(buf, nc->sram.virt, mtd->writesize);
 
        if (oob_required)
                memcpy_fromio(chip->oob_poi, nc->sram.virt + mtd->writesize,