git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b4d2314
)
NFS: Avoid a deadlock in nfs_release_page
author
Trond Myklebust
<Trond.Myklebust@netapp.com>
Thu, 11 Mar 2010 14:19:35 +0000
(09:19 -0500)
committer
Trond Myklebust
<Trond.Myklebust@netapp.com>
Thu, 11 Mar 2010 14:19:35 +0000
(09:19 -0500)
J.R. Okajima reports the following deadlock:
INFO: task kswapd0:305 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
kswapd0 D
0000000000000001
0 305 2 0x00000000
ffff88001f21d4f0
0000000000000046
ffff88001fdea680
ffff88001f21c000
ffff88001f21dfd8
ffff88001f21c000
ffff88001f21dfd8
ffff88001f21dfd8
ffff88001fdea040
0000000000014c00
0000000000000001
ffff88001fdea040
Call Trace:
[<
ffffffff8146155d
>] io_schedule+0x4d/0x70
[<
ffffffff810d2be5
>] sync_page+0x65/0xa0
[<
ffffffff81461b12
>] __wait_on_bit_lock+0x52/0xb0
[<
ffffffff810d2b80
>] ? sync_page+0x0/0xa0
[<
ffffffff810d2b64
>] __lock_page+0x64/0x70
[<
ffffffff81070ce0
>] ? wake_bit_function+0x0/0x40
[<
ffffffff810df1d4
>] truncate_inode_pages_range+0x344/0x4a0
[<
ffffffff810df340
>] truncate_inode_pages+0x10/0x20
[<
ffffffff8112cbfe
>] generic_delete_inode+0x15e/0x190
[<
ffffffff8112cc8d
>] generic_drop_inode+0x5d/0x80
[<
ffffffff8112bb88
>] iput+0x78/0x80
[<
ffffffff811bc908
>] nfs_dentry_iput+0x38/0x50
[<
ffffffff811285f4
>] dentry_iput+0x84/0x110
[<
ffffffff811286ae
>] d_kill+0x2e/0x60
[<
ffffffff8112912a
>] dput+0x7a/0x170
[<
ffffffff8111e925
>] path_put+0x15/0x40
[<
ffffffff811c3a44
>] __put_nfs_open_context+0xa4/0xb0
[<
ffffffff811cb5d0
>] ? nfs_free_request+0x0/0x50
[<
ffffffff811c3b0b
>] put_nfs_open_context+0xb/0x10
[<
ffffffff811cb5f9
>] nfs_free_request+0x29/0x50
[<
ffffffff81234b7e
>] kref_put+0x8e/0xe0
[<
ffffffff811cb594
>] nfs_release_request+0x14/0x20
[<
ffffffff811cf769
>] nfs_find_and_lock_request+0x89/0xa0
[<
ffffffff811d1180
>] nfs_wb_page+0x80/0x110
[<
ffffffff811c0770
>] nfs_release_page+0x70/0x90
[<
ffffffff810d18ee
>] try_to_release_page+0x5e/0x80
[<
ffffffff810e1178
>] shrink_page_list+0x638/0x860
[<
ffffffff810e19de
>] shrink_zone+0x63e/0xc40
We can fix this by making the call to put_nfs_open_context() happen when we
actually remove the write request from the inode (which is done by the
nfsiod thread in this case).
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@kernel.org
No differences found