arm64: zynqmp: Fix usb node drive strength and slew rate
authorAshok Reddy Soma <ashok.reddy.soma@xilinx.com>
Wed, 15 Jun 2022 10:16:13 +0000 (12:16 +0200)
committerMichal Simek <michal.simek@amd.com>
Fri, 24 Jun 2022 12:17:18 +0000 (14:17 +0200)
As per design, all input/rx pins should have fast slew rate and 12mA
drive strength. Rest all pins should be slow slew rate and 4mA drive
strength. Fix usb nodes as per this and remove setting of slow slew rate
for all the usb gorup pins.

Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/b245c165f05845c1f3ab41a92c82b7ec1538cee4.1655288171.git.michal.simek@amd.com
12 files changed:
arch/arm/dts/zynqmp-sck-kr-g-revA.dts
arch/arm/dts/zynqmp-sck-kr-g-revB.dts
arch/arm/dts/zynqmp-sck-kv-g-revA.dts
arch/arm/dts/zynqmp-sck-kv-g-revB.dts
arch/arm/dts/zynqmp-zc1751-xm015-dc1.dts
arch/arm/dts/zynqmp-zc1751-xm016-dc2.dts
arch/arm/dts/zynqmp-zcu100-revC.dts
arch/arm/dts/zynqmp-zcu102-revA.dts
arch/arm/dts/zynqmp-zcu104-revA.dts
arch/arm/dts/zynqmp-zcu104-revC.dts
arch/arm/dts/zynqmp-zcu106-revA.dts
arch/arm/dts/zynqmp-zcu111-revA.dts

index 7be02ab..735c1e3 100644 (file)
        pinctrl_usb0_default: usb0-default {
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                        "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
 
                mux {
        pinctrl_usb1_default: usb1-default {
                conf {
                        groups = "usb1_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO64", "MIO65", "MIO67";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO66", "MIO68", "MIO69", "MIO70", "MIO71",
                        "MIO72", "MIO73", "MIO74", "MIO75";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
 
                mux {
index 56effb5..6359061 100644 (file)
        pinctrl_usb0_default: usb0-default {
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                        "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
 
                mux {
        pinctrl_usb1_default: usb1-default {
                conf {
                        groups = "usb1_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO64", "MIO65", "MIO67";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO66", "MIO68", "MIO69", "MIO70", "MIO71",
                        "MIO72", "MIO73", "MIO74", "MIO75";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
 
                mux {
index 8250a49..b714bd3 100644 (file)
        pinctrl_usb0_default: usb0-default {
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                        "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
 
                mux {
index b81c2e6..a1d8f9f 100644 (file)
        pinctrl_usb0_default: usb0-default {
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                        "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
 
                mux {
index d20f667..7ea2a1c 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 
index f32f87a..4e6160b 100644 (file)
 
                conf {
                        groups = "usb1_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO64", "MIO65", "MIO67";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO66", "MIO68", "MIO69", "MIO70", "MIO71",
                               "MIO72", "MIO73", "MIO74", "MIO75";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 
index ea630a4..5e7bc73 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 
 
                conf {
                        groups = "usb1_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO64", "MIO65", "MIO67";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO66", "MIO68", "MIO69", "MIO70", "MIO71",
                               "MIO72", "MIO73", "MIO74", "MIO75";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 };
index c13b52a..a4e92c8 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 
index 50bf479..1418cff 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
-                       drive-strength = <12>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 };
index 752a9e3..7fd19ca 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
-                       drive-strength = <12>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 };
index 6dfc8fe..3e13767 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };
 
index 021fe88..e412992 100644 (file)
 
                conf {
                        groups = "usb0_0_grp";
-                       slew-rate = <SLEW_RATE_SLOW>;
                        power-source = <IO_STANDARD_LVCMOS18>;
                };
 
                conf-rx {
                        pins = "MIO52", "MIO53", "MIO55";
                        bias-high-impedance;
+                       drive-strength = <12>;
+                       slew-rate = <SLEW_RATE_FAST>;
                };
 
                conf-tx {
                        pins = "MIO54", "MIO56", "MIO57", "MIO58", "MIO59",
                               "MIO60", "MIO61", "MIO62", "MIO63";
                        bias-disable;
+                       drive-strength = <4>;
+                       slew-rate = <SLEW_RATE_SLOW>;
                };
        };