git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ebb36a9
)
tcp: Fix bitmask test in tcp_syn_options()
author
David S. Miller
<davem@davemloft.net>
Tue, 22 Jul 2008 01:45:34 +0000
(18:45 -0700)
committer
David S. Miller
<davem@davemloft.net>
Tue, 22 Jul 2008 01:45:34 +0000
(18:45 -0700)
As reported by Alexey Dobriyan:
CHECK net/ipv4/tcp_output.c
net/ipv4/tcp_output.c:475:7: warning: dubious: !x & y
And sparse is damn right!
if (unlikely(!OPTION_TS & opts->options))
^^^
size += TCPOLEN_SACKPERM_ALIGNED;
OPTION_TS is (1 << 1), so condition will never trigger.
Signed-off-by: David S. Miller <davem@davemloft.net>
No differences found