workqueue: better define synchronization rule around rescuer->pool updates
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 19 Feb 2013 20:17:02 +0000 (12:17 -0800)
committerTejun Heo <tj@kernel.org>
Mon, 4 Mar 2013 17:44:58 +0000 (09:44 -0800)
Rescuers visit different worker_pools to process work items from pools
under pressure.  Currently, rescuer->pool is updated outside any
locking and when an outsider looks at a rescuer, there's no way to
tell when and whether rescuer->pool is gonna change.  While this
doesn't currently cause any problem, it is nasty.

With recent worker_maybe_bind_and_lock() changes, we can move
rescuer->pool updates inside pool locks such that if rescuer->pool
equals a locked pool, it's guaranteed to stay that way until the pool
is unlocked.

Move rescuer->pool inside pool->lock.

This patch doesn't introduce any visible behavior difference.

tj: Updated the description.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

No differences found