clk: mediatek: fix uninitialized fields issue in INFRA_MUX struct
authorWeijie Gao <weijie.gao@mediatek.com>
Fri, 17 Jan 2025 09:16:38 +0000 (17:16 +0800)
committerTom Rini <trini@konsulko.com>
Thu, 23 Jan 2025 18:11:49 +0000 (12:11 -0600)
This patch adds missing initialization of fields in INFRA_MUX struct
which caused uart broken after any other infra mux being enabled by
'clk_prepare_enable'

Signed-off-by: Sam Shih <sam.shih@mediatek.com>
Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
drivers/clk/mediatek/clk-mt7981.c
drivers/clk/mediatek/clk-mt7986.c
drivers/clk/mediatek/clk-mt7988.c

index 9707391..6081465 100644 (file)
@@ -359,6 +359,7 @@ static const struct mtk_parent infra_pcie_parents[] = {
                .id = _id, .mux_reg = (_reg) + 0x8,                            \
                .mux_set_reg = (_reg) + 0x0, .mux_clr_reg = (_reg) + 0x4,      \
                .mux_shift = _shift, .mux_mask = BIT(_width) - 1,              \
+               .gate_shift = -1, .upd_shift = -1,                             \
                .parent_flags = _parents, .num_parents = ARRAY_SIZE(_parents), \
                .flags = CLK_MUX_SETCLR_UPD | CLK_PARENT_MIXED,                \
        }
index c5cc772..f9d6f9c 100644 (file)
@@ -366,6 +366,7 @@ static const struct mtk_parent infra_pcie_parents[] = {
                .id = _id, .mux_reg = (_reg) + 0x8,                            \
                .mux_set_reg = (_reg) + 0x0, .mux_clr_reg = (_reg) + 0x4,      \
                .mux_shift = _shift, .mux_mask = BIT(_width) - 1,              \
+               .gate_shift = -1, .upd_shift = -1,                             \
                .parent_flags = _parents, .num_parents = ARRAY_SIZE(_parents), \
                .flags = CLK_MUX_SETCLR_UPD | CLK_PARENT_MIXED,                \
        }
index 8f4e8f4..73fd9c6 100644 (file)
@@ -485,6 +485,7 @@ static const int infra_pcie_gfmux_tl_ck_o_p3_parents[] = {
                .id = _id, .mux_reg = _reg + 0x8, .mux_set_reg = _reg + 0x0,   \
                .mux_clr_reg = _reg + 0x4, .mux_shift = _shift,                \
                .mux_mask = BIT(_width) - 1, .parent = _parents,               \
+               .gate_shift = -1, .upd_shift = -1,                             \
                .num_parents = ARRAY_SIZE(_parents),                           \
                .flags = CLK_MUX_SETCLR_UPD | CLK_PARENT_TOPCKGEN,             \
        }