Merge patch series "binman: Check code-coverage requirements"
authorTom Rini <trini@konsulko.com>
Fri, 11 Apr 2025 20:32:02 +0000 (14:32 -0600)
committerTom Rini <trini@konsulko.com>
Fri, 11 Apr 2025 22:47:29 +0000 (16:47 -0600)
Simon Glass <sjg@chromium.org> says:

This series adds a cover-coverage check to CI for Binman. The iMX8 tests
are still not completed, so a work-around is included for those.

A few fixes are included for some other problems.

Link: https://lore.kernel.org/r/20250410124333.843527-1-sjg@chromium.org
1  2 
.azure-pipelines.yml
.gitlab-ci.yml

@@@ -144,8 -144,10 +144,11 @@@ stages
            export PATH=${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}
            ./tools/buildman/buildman -T0 -o ${UBOOT_TRAVIS_BUILD_DIR} -w --board tools-only
            set -ex
-           ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools tool -f missing
-           ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools test
+           export TOOLPATH="--toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools --toolpath /opt/coreboot"
++          ./tools/binman/binman ${TOOLPATH} tool -f missing
+           ./tools/binman/binman ${TOOLPATH} test
+           # Avoid "Permission denied: 'cov'" error by using a temporary file
+           COVERAGE_FILE=/tmp/.coverage ./tools/binman/binman ${TOOLPATH} test -T
            ./tools/buildman/buildman -t
            ./tools/dtoc/dtoc -t
            ./tools/patman/patman test
diff --cc .gitlab-ci.yml
@@@ -196,8 -196,9 +196,10 @@@ Run binman, buildman, dtoc, Kconfig an
        ./tools/buildman/buildman -T0 -o ${UBOOT_TRAVIS_BUILD_DIR} -w
          --board tools-only;
        set -e;
-       ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools tool -f missing;
-       ./tools/binman/binman --toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools test;
+       export TOOLPATH="--toolpath ${UBOOT_TRAVIS_BUILD_DIR}/tools --toolpath /opt/coreboot";
++      ./tools/binman/binman ${TOOLPATH} tool -f missing;
+       ./tools/binman/binman ${TOOLPATH} test;
+       ./tools/binman/binman ${TOOLPATH} test -T;
        ./tools/buildman/buildman -t;
        ./tools/dtoc/dtoc -t;
        ./tools/patman/patman test;