ARM: mvebu: Correct SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR usage
authorTom Rini <trini@konsulko.com>
Sat, 15 Mar 2025 01:29:05 +0000 (19:29 -0600)
committerStefan Roese <sr@denx.de>
Wed, 16 Apr 2025 06:05:15 +0000 (08:05 +0200)
As the code is today, we get a warning about "select" statements on
"choice" options not doing anything. However, it also works as intended
because SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is the default option
within that choice statement. To guard against future regressions, make
the choice statement in common/spl/Kconfig have an explicit default if
MVEBU_SPL_BOOT_DEVICE_MMC.

Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Stefan Roese <sr@denx.de>
arch/arm/mach-mvebu/Kconfig
common/spl/Kconfig

index 22180b0..b76510a 100644 (file)
@@ -394,7 +394,6 @@ config MVEBU_SPL_BOOT_DEVICE_MMC
        imply SPL_LIBDISK_SUPPORT
        imply SPL_MMC
        select SUPPORT_EMMC_BOOT if SPL_MMC
-       select SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR if SPL_MMC
        select SPL_BOOTROM_SUPPORT
 
 config MVEBU_SPL_BOOT_DEVICE_SATA
index c08045f..3282e08 100644 (file)
@@ -537,6 +537,7 @@ if SPL_SYS_MMCSD_RAW_MODE
 
 choice
        prompt "Method for locating next phase of boot (e.g. U-Boot)"
+       default SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR if MVEBU_SPL_BOOT_DEVICE_MMC
 
 config SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR
        bool "MMC raw mode: by sector"