mmc: renesas-sdhi: Send stop when MMC tuning command fails
authorHai Pham <hai.pham.ud@renesas.com>
Mon, 19 Jun 2023 22:38:25 +0000 (00:38 +0200)
committerJaehoon Chung <jh80.chung@samsung.com>
Tue, 18 Jul 2023 00:17:23 +0000 (09:17 +0900)
When tuning command (CMD21) fails with command error, call
mmc_send_stop_transmission() to send stop command (CMD12).

Reviewed-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[Marek: Add dev_dbg() message in case tuning abort fails
        Move tuning opcode check from mmc_abort_tuning()]
Reviewed-by: Peng Fan <peng.fan@nxp.com>
drivers/mmc/renesas-sdhi.c

index 280d96d..8e716f7 100644 (file)
@@ -611,6 +611,17 @@ int renesas_sdhi_execute_tuning(struct udevice *dev, uint opcode)
                        priv->smpcmp |= BIT(i);
 
                mdelay(1);
+
+               /*
+                * eMMC specification specifies that CMD12 can be used to stop a tuning
+                * command, but SD specification does not, so do nothing unless it is
+                * eMMC.
+                */
+               if (ret && (opcode == MMC_CMD_SEND_TUNING_BLOCK_HS200)) {
+                       ret = mmc_send_stop_transmission(mmc, false);
+                       if (ret < 0)
+                               dev_dbg(dev, "Tuning abort fail (%d)\n", ret);
+               }
        }
 
        ret = renesas_sdhi_select_tuning(priv, taps);