git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9d04cba
)
leds: renesas: set gpio_request_one() flags param correctly
author
Jingoo Han
<jg1.han@samsung.com>
Fri, 8 Mar 2013 02:39:04 +0000
(18:39 -0800)
committer
Bryan Wu
<cooloney@gmail.com>
Mon, 1 Apr 2013 18:04:49 +0000
(11:04 -0700)
The gpio_request_one() flags parameter was set to:
GPIOF_DIR_OUT | !!brightness
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:
GPIOF_DIR_OUT (0 << 0)
GPIOF_DIR_IN (1 << 0)
So, when '!!brightness' is 1, the gpio pin can be set as input,
instead of output.
To prevent this problem, GPIOF_OUT_INIT flags should be used when
using gpio_request_one().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
drivers/leds/leds-renesas-tpu.c
patch
|
blob
|
history
diff --cc
drivers/leds/leds-renesas-tpu.c
Simple merge