git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bfc978f
)
net: dccp: fix sign bug
author
Kulikov Vasiliy
<segooon@gmail.com>
Sat, 17 Jul 2010 05:21:00 +0000
(
05:21
+0000)
committer
David S. Miller
<davem@davemloft.net>
Sun, 18 Jul 2010 22:07:14 +0000
(15:07 -0700)
'gap' is unsigned, so this code is wrong:
gap = -new_head;
...
if (gap > 0) { ... }
Make 'gap' signed.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }
@@
identifier r1.f;
type T;
unsigned T x;
@@
*x = f(...)
...
*x > 0
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ackvec.c
patch
|
blob
|
history
diff --cc
net/dccp/ackvec.c
Simple merge