i7core_edac: it is safe to i7core_unregister_mci() when mci=NULL
authorMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 20 Aug 2010 18:39:38 +0000 (15:39 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 24 Oct 2010 13:20:41 +0000 (11:20 -0200)
i7core_unregister_mci() checks internally when mci=NULL. There's no
need to test it outside.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/edac/i7core_edac.c

index 9158353..d55f74a 100644 (file)
@@ -2091,10 +2091,9 @@ static int __devinit i7core_probe(struct pci_dev *pdev,
        return 0;
 
 fail1:
-       list_for_each_entry(i7core_dev, &i7core_edac_list, list) {
-               if (i7core_dev->mci)
-                       i7core_unregister_mci(i7core_dev);
-       }
+       list_for_each_entry(i7core_dev, &i7core_edac_list, list)
+               i7core_unregister_mci(i7core_dev);
+
        i7core_put_all_devices();
 fail0:
        mutex_unlock(&i7core_edac_lock);
@@ -2126,10 +2125,8 @@ static void __devexit i7core_remove(struct pci_dev *pdev)
                return;
        }
 
-       list_for_each_entry(i7core_dev, &i7core_edac_list, list) {
-               if (i7core_dev->mci)
-                       i7core_unregister_mci(i7core_dev);
-       }
+       list_for_each_entry(i7core_dev, &i7core_edac_list, list)
+               i7core_unregister_mci(i7core_dev);
 
        /* Release PCI resources */
        i7core_put_all_devices();