Input: wacom - cleanup a return value for the old Bamboo
authorPing Cheng <pinglinux@gmail.com>
Thu, 7 Jul 2011 01:05:43 +0000 (18:05 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 7 Jul 2011 04:24:35 +0000 (21:24 -0700)
The old code may call input_sync() without sending any other events.
While it will be suppressed by the input core not calling it at all
is still cheaper.

Signed-off-by: Ping Cheng <pingc@wacom.com>
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
Reviewed-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/tablet/wacom_wac.c

index 19554a4..03ebcc8 100644 (file)
@@ -300,8 +300,8 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
                                wacom->id[1] = 0;
                        input_report_abs(input, ABS_MISC, wacom->id[1]);
                        input_event(input, EV_MSC, MSC_SERIAL, 0xf0);
+                       retval = 1;
                }
-               retval = 1;
                break;
        }
 exit: