bios_emulator: fix garbled printing of disassembled SET* instructions
authorYuri Zaporozhets <yuriz@qrv-systems.net>
Tue, 26 Nov 2024 23:29:53 +0000 (00:29 +0100)
committerTom Rini <trini@konsulko.com>
Sun, 15 Dec 2024 17:39:18 +0000 (11:39 -0600)
When DEBUG_DECODE_F is enabled in bios_emulator, the printing of
SET{O,NO,B,NB,Z,NZ,BE,NBE,S,NS,P,TP,L,NL,LE,NLE} instructions
is not followed by newline and is, therefore, immediately followed
by the printed address of a new instruction. This garbles the output
and makes it very difficult to read.

This patch adds missing DECODE_PRINTF("\n") calls to print newlines.

Signed-off-by: Yuri Zaporozhets <yuriz@qrv-systems.net>
drivers/bios_emulator/x86emu/ops2.c

index 4327010..1ff27b2 100644 (file)
@@ -245,10 +245,12 @@ void x86emuOp2_set_byte(u8 op2)
     FETCH_DECODE_MODRM(mod, rh, rl);
     if (mod < 3) {
        destoffset = decode_rmXX_address(mod, rl);
+       DECODE_PRINTF("\n");
        TRACE_AND_STEP();
        store_data_byte(destoffset, cond ? 0x01 : 0x00);
     } else {                    /* register to register */
        destreg = DECODE_RM_BYTE_REGISTER(rl);
+       DECODE_PRINTF("\n");
        TRACE_AND_STEP();
        *destreg = cond ? 0x01 : 0x00;
     }