net: phy: broadcom: fix RGMII delays for BCM54210E

bcm54210e_config() configures the RGMII delays and then calls
bcm5461_config(). But the latter will do a PHY soft reset and thus
resets the delay settings again. Call bcm5461_config() first to fix it.

Fixes: cba79a1b2e11 ("net: phy: broadcom: add support for BCM54210E")
Signed-off-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Rafał Miłecki <rafal@milecki.pl>

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 1c02e3e..2d93ce0 100644 (file)
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -176,11 +176,11 @@ static int bcm54210e_config(struct phy_device *phydev)
 {
        int ret;
 
-       ret = bcm54xx_config_clock_delay(phydev);
+       ret = bcm5461_config(phydev);
        if (ret < 0)
                return ret;
 
-       ret = bcm5461_config(phydev);
+       ret = bcm54xx_config_clock_delay(phydev);
        if (ret < 0)
                return ret;