usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Tue, 26 Nov 2024 12:03:18 +0000 (17:33 +0530)
committerTom Rini <trini@konsulko.com>
Fri, 13 Dec 2024 20:14:25 +0000 (14:14 -0600)
There are only two callers of "dwc3_generic_probe()", namely:
1. dwc3_generic_peripheral_probe()
2. dwc3_generic_host_probe()
Currently, the "mode" is set based on the device-tree node of the
platform device. Also, the DWC3 core doesn't support updating the "mode"
dynamically at runtime if it is set to "OTG", i.e. "OTG" is treated as a
separate mode in itself, rather than being treated as a mode which should
eventually lead to "host"/"peripheral".

Given that the callers of "dwc3_generic_probe()" clarify the expected
"mode" of the USB Controller, use that "mode" instead of the one
specified in the device-tree. This shall allow the USB Controller to
function both as a "Host" and as a "Peripheral" when the "mode" is "otg"
in the device-tree, based on the caller of "dwc3_generic_probe()".

Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
drivers/usb/dwc3/dwc3-generic.c

index 2ab41cb..55e62b3 100644 (file)
@@ -51,7 +51,8 @@ struct dwc3_generic_host_priv {
 };
 
 static int dwc3_generic_probe(struct udevice *dev,
-                             struct dwc3_generic_priv *priv)
+                             struct dwc3_generic_priv *priv,
+                             enum usb_dr_mode mode)
 {
        int rc;
        struct dwc3_generic_plat *plat = dev_get_plat(dev);
@@ -62,7 +63,7 @@ static int dwc3_generic_probe(struct udevice *dev,
 
        dwc3->dev = dev;
        dwc3->maximum_speed = plat->maximum_speed;
-       dwc3->dr_mode = plat->dr_mode;
+       dwc3->dr_mode = mode;
 #if CONFIG_IS_ENABLED(OF_CONTROL)
        dwc3_of_parse(dwc3);
 
@@ -197,7 +198,7 @@ static int dwc3_generic_peripheral_probe(struct udevice *dev)
 {
        struct dwc3_generic_priv *priv = dev_get_priv(dev);
 
-       return dwc3_generic_probe(dev, priv);
+       return dwc3_generic_probe(dev, priv, USB_DR_MODE_PERIPHERAL);
 }
 
 static int dwc3_generic_peripheral_remove(struct udevice *dev)
@@ -241,7 +242,7 @@ static int dwc3_generic_host_probe(struct udevice *dev)
        struct dwc3_generic_host_priv *priv = dev_get_priv(dev);
        int rc;
 
-       rc = dwc3_generic_probe(dev, &priv->gen_priv);
+       rc = dwc3_generic_probe(dev, &priv->gen_priv, USB_DR_MODE_HOST);
        if (rc)
                return rc;