phy: cadence: sierra: Remove variable that is not assigned to

In cdns_sierra_pll_bind_of_clocks the variable 'i' is declared but never
assigned to before its value is used in a dev_err. Replace clk_names[i]
by the name passed to device_bind(), i.e., "pll_mux_clk". With that, the
clk_names[] array is unused and can therefore be removed.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
[jf: update description]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
index 2c9d5a1..bd7ab9d 100644 (file)
--- a/drivers/phy/cadence/phy-cadence-sierra.c
+++ b/drivers/phy/cadence/phy-cadence-sierra.c
@@ -225,11 +225,6 @@ static const struct reg_field pllctrl_lock =
 static const struct reg_field phy_iso_link_ctrl_1 =
                                REG_FIELD(SIERRA_PHY_ISO_LINK_CTRL, 1, 1);
 
-static const char * const clk_names[] = {
-       [CDNS_SIERRA_PLL_CMNLC] = "pll_cmnlc",
-       [CDNS_SIERRA_PLL_CMNLC1] = "pll_cmnlc1",
-};
-
 enum cdns_sierra_cmn_plllc {
        CMN_PLLLC,
        CMN_PLLLC1,
@@ -602,7 +597,7 @@ static int cdns_sierra_pll_bind_of_clocks(struct cdns_sierra_phy *sp)
        struct udevice *dev = sp->dev;
        struct driver *cdns_sierra_clk_drv;
        struct cdns_sierra_pll_mux_sel *data = pll_clk_mux_sel;
-       int i, rc;
+       int rc;
 
        cdns_sierra_clk_drv = lists_driver_lookup_name("cdns_sierra_mux_clk");
        if (!cdns_sierra_clk_drv) {
@@ -612,10 +607,8 @@ static int cdns_sierra_pll_bind_of_clocks(struct cdns_sierra_phy *sp)
 
        rc = device_bind(dev, cdns_sierra_clk_drv, "pll_mux_clk",
                         data, dev_ofnode(dev), NULL);
-       if (rc) {
-               dev_err(dev, "cannot bind driver for clock %s\n",
-                       clk_names[i]);
-       }
+       if (rc)
+               dev_err(dev, "cannot bind driver for clock pll_mux_clk\n");
 
        return 0;
 }