efi_loader: optional pointer for ConvertPointer
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Tue, 24 Mar 2020 16:52:40 +0000 (17:52 +0100)
committerHeinrich Schuchardt <xypron.glpk@gmx.de>
Sat, 11 Jul 2020 21:14:17 +0000 (23:14 +0200)
If the EFI_OPTIONAL_PTR is set in DebugDisposition, a NULL pointer does not
constitute an invalid parameter.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
include/efi_api.h
lib/efi_loader/efi_runtime.c

index 759d911..5744f6a 100644 (file)
@@ -251,6 +251,8 @@ struct efi_rt_properties_table {
        u32 runtime_services_supported;
 };
 
+#define EFI_OPTIONAL_PTR       0x00000001
+
 struct efi_runtime_services {
        struct efi_table_hdr hdr;
        efi_status_t (EFIAPI *get_time)(struct efi_time *time,
index 45baa2f..a4aa1d8 100644 (file)
@@ -512,6 +512,12 @@ efi_convert_pointer(efi_uintn_t debug_disposition, void **address)
                ret = EFI_INVALID_PARAMETER;
                goto out;
        }
+       if (!*address) {
+               if (debug_disposition & EFI_OPTIONAL_PTR)
+                       return EFI_SUCCESS;
+               else
+                       return EFI_INVALID_PARAMETER;
+       }
 
        addr = (uintptr_t)*address;
        for (i = 0; i < efi_descriptor_count; i++) {