[SCSI] bnx2i: Added reconnect fix connecting against Lefthand targets
authorEddie Wai <eddie.wai@broadcom.com>
Sun, 9 Jan 2011 02:00:24 +0000 (18:00 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Mon, 24 Jan 2011 17:40:30 +0000 (11:40 -0600)
The nopout's reserved field was not being initialized to zero
before being reused.  Stale CDB values from previous SCSI cmds
of the same BHS offset was the cause of the disconnection
initiated by the Lefthand target.

Signed-off-by: Eddie Wai <eddie.wai@broadcom.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/bnx2i/bnx2i_hwi.c

index 96505e3..603db9d 100644 (file)
@@ -490,6 +490,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn *bnx2i_conn,
        bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
        nopout_hdr = (struct iscsi_nopout *)task->hdr;
        nopout_wqe = (struct bnx2i_nop_out_request *)ep->qp.sq_prod_qe;
+
+       memset(nopout_wqe, 0x00, sizeof(struct bnx2i_nop_out_request));
+
        nopout_wqe->op_code = nopout_hdr->opcode;
        nopout_wqe->op_attr = ISCSI_FLAG_CMD_FINAL;
        memcpy(nopout_wqe->lun, nopout_hdr->lun, 8);