gpu: pvr: Changed ReallocMem.
authorJanusz Sobczak <janusz.sobczak@imgtec.com>
Mon, 9 Aug 2010 11:22:04 +0000 (13:22 +0200)
committerGrazvydas Ignotas <notasas@gmail.com>
Sun, 20 May 2012 18:09:42 +0000 (21:09 +0300)
A static analysis tool showed a possible defect in ReallocMem() -
derefencing a null pointer. It was a false positive.

This patch slightly modifies ReallocMem() to avoid this warning.

Signed-off-by: Janusz Sobczak <janusz.sobczak@imgtec.com>
Signed-off-by: Imre Deak <imre.deak@nokia.com>
pvr/handle.c

index bced654..f1c8f83 100644 (file)
@@ -582,11 +582,10 @@ static enum PVRSRV_ERROR ReallocMem(void **ppvMem, void **phBlockAlloc,
                                 eError);
                        return eError;
                }
+               if (ui32OldSize != 0)
+                       OSMemCopy(pvNewMem, pvOldMem, ui32CopySize);
        }
 
-       if (ui32CopySize != 0)
-               OSMemCopy(pvNewMem, pvOldMem, ui32CopySize);
-
        if (ui32OldSize != 0)
                OSFreeMem(PVRSRV_OS_PAGEABLE_HEAP, ui32OldSize, pvOldMem,
                          hOldBlockAlloc);