ath9k_htc: check for underflow in ath9k_htc_rx_msg()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 6 Nov 2015 10:01:20 +0000 (13:01 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 13 Feb 2016 10:34:04 +0000 (10:34 +0000)
commit 3a318426e09a9c9266fe6440842e11238f640a20 upstream.

We check for overflow here, but we don't check for underflow so it
causes a static checker warning.

Fixes: fb9987d0f748 ('ath9k_htc: Support for AR9271 chipset.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/ath/ath9k/htc_hst.c

index 4f7843a..51e256e 100644 (file)
@@ -377,7 +377,7 @@ void ath9k_htc_rx_msg(struct htc_target *htc_handle,
        htc_hdr = (struct htc_frame_hdr *) skb->data;
        epid = htc_hdr->endpoint_id;
 
-       if (epid >= ENDPOINT_MAX) {
+       if (epid < 0 || epid >= ENDPOINT_MAX) {
                if (pipe_id != USB_REG_IN_PIPE)
                        dev_kfree_skb_any(skb);
                else