git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a1412ec
)
nohz: Protect smp_processor_id() in tick_nohz_task_switch()
author
Li Zhong
<zhong@linux.vnet.ibm.com>
Sun, 28 Apr 2013 03:25:58 +0000
(11:25 +0800)
committer
Ingo Molnar
<mingo@kernel.org>
Mon, 29 Apr 2013 11:17:33 +0000
(13:17 +0200)
I saw following error when testing the latest nohz code on
Power:
[ 85.295384] BUG: using smp_processor_id() in preemptible [
00000000
] code: rsyslogd/3493
[ 85.295396] caller is .tick_nohz_task_switch+0x1c/0xb8
[ 85.295402] Call Trace:
[ 85.295408] [
c0000001fababab0
] [
c000000000012dc4
] .show_stack+0x110/0x25c (unreliable)
[ 85.295420] [
c0000001fababba0
] [
c0000000007c4b54
] .dump_stack+0x20/0x30
[ 85.295430] [
c0000001fababc10
] [
c00000000044eb74
] .debug_smp_processor_id+0xf4/0x124
[ 85.295438] [
c0000001fababca0
] [
c0000000000d7594
] .tick_nohz_task_switch+0x1c/0xb8
[ 85.295447] [
c0000001fababd20
] [
c0000000000b9748
] .finish_task_switch+0x13c/0x160
[ 85.295455] [
c0000001fababdb0
] [
c0000000000bbe50
] .schedule_tail+0x50/0x124
[ 85.295463] [
c0000001fababe30
] [
c000000000009dc8
] .ret_from_fork+0x4/0x54
The code below moves the test into local_irq_save/restore
section to avoid the above complaint.
Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
Link:
http://lkml.kernel.org/r/1367119558.6391.34.camel@ThinkPad-T5421.cn.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
No differences found