test: Adjust print_ut test to use unsigned char
authorSimon Glass <sjg@chromium.org>
Wed, 27 Nov 2024 17:17:20 +0000 (11:17 -0600)
committerTom Rini <trini@konsulko.com>
Mon, 2 Dec 2024 22:34:30 +0000 (16:34 -0600)
Since char is unsigned on arm64, this test currently fails. It seems
better to use unsigned anyway, since 0xff is written into the string at
the start. Update the terminator-assert to use a character instead of a
byte.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Changes in v6:
- Re-introduce

Changes in v2:
- Use '\0' instead of 0

test/print_ut.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

test/common/print.c

index 464e425..e3711b1 100644 (file)
@@ -241,7 +241,7 @@ COMMON_TEST(print_display_buffer, UTF_CONSOLE);
 
 static int print_hexdump_line(struct unit_test_state *uts)
 {
-       char *linebuf;
+       u8 *linebuf;
        u8 *buf;
        int i;
 
@@ -254,10 +254,10 @@ static int print_hexdump_line(struct unit_test_state *uts)
        linebuf = map_sysmem(0x400, BUF_SIZE);
        memset(linebuf, '\xff', BUF_SIZE);
        ut_asserteq(-ENOSPC, hexdump_line(0, buf, 1, 0x10, 0, linebuf, 75));
-       ut_asserteq(-1, linebuf[0]);
+       ut_asserteq(0xff, linebuf[0]);
        ut_asserteq(0x10, hexdump_line(0, buf, 1, 0x10, 0, linebuf, 76));
-       ut_asserteq(0, linebuf[75]);
-       ut_asserteq(-1, linebuf[76]);
+       ut_asserteq('\0', linebuf[75]);
+       ut_asserteq(0xff, linebuf[76]);
 
        unmap_sysmem(buf);