vhost: vhost_scsi_handle_vq() should just use copy_from_user()
authorAl Viro <viro@zeniv.linux.org.uk>
Wed, 10 Dec 2014 21:03:43 +0000 (16:03 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 4 Feb 2015 06:34:16 +0000 (01:34 -0500)
it has just verified that it asks no more than the length of the
first segment of iovec.

And with that the last user of stuff in lib/iovec.c is gone.
RIP.

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Nicholas A. Bellinger <nab@linux-iscsi.org>
Cc: kvm@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/vhost/scsi.c
include/linux/uio.h
lib/Makefile
lib/iovec.c [deleted file]

index d695b16..dc78d87 100644 (file)
@@ -1079,7 +1079,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq)
                               req_size, vq->iov[0].iov_len);
                        break;
                }
-               ret = memcpy_fromiovecend(req, &vq->iov[0], 0, req_size);
+               ret = copy_from_user(req, vq->iov[0].iov_base, req_size);
                if (unlikely(ret)) {
                        vq_err(vq, "Faulted on virtio_scsi_cmd_req\n");
                        break;
Simple merge
diff --cc lib/Makefile
Simple merge
diff --cc lib/iovec.c
Simple merge