net: stmmac: sti: Fix uninitialized pointer dereference if !OF
authorGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 15 Dec 2014 11:25:51 +0000 (12:25 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Dec 2014 16:48:02 +0000 (11:48 -0500)
If CONFIG_OF is not set:

drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function ‘sti_dwmac_parse_data’:
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:318: warning: ‘rs’ is used uninitialized in this function

of_property_read_string() will return -ENOSYS in this case, and rs will
be an uninitialized pointer.

While the fallback clock selection is already selected correctly in this
case, the string comparisons should be skipped too, else the system will
crash while dereferencing the uninitialized pointer.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

No differences found