git.openpandora.org
/
pandora-u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a673292
)
cmd: abootimg: Prevent use of unintialised variable
author
Andrew Goodbody
<andrew.goodbody@linaro.org>
Thu, 26 Jun 2025 16:38:54 +0000
(17:38 +0100)
committer
Mattijs Korpershoek
<mkorpershoek@kernel.org>
Wed, 2 Jul 2025 10:10:04 +0000
(12:10 +0200)
Initialise vhdr to prevent its use when uninitialised.
This issue was found with Smatch.
Fixes:
636da2039aea
(android: boot: support boot image header version 3 and 4)
Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Link:
https://lore.kernel.org/r/20250625-abootimg_fix-v4-1-df7af00e87b0@linaro.org
[mkorpershoek: fixed trivial typo in commit msg]
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
cmd/abootimg.c
patch
|
blob
|
history
diff --git
a/cmd/abootimg.c
b/cmd/abootimg.c
index
44de00f
..
6fb5215
100644
(file)
--- a/
cmd/abootimg.c
+++ b/
cmd/abootimg.c
@@
-96,7
+96,7
@@
static int abootimg_get_dtb_load_addr(int argc, char *const argv[])
return CMD_RET_USAGE;
struct andr_image_data img_data = {0};
const struct andr_boot_img_hdr_v0 *hdr;
- const struct andr_vnd_boot_img_hdr *vhdr;
+ const struct andr_vnd_boot_img_hdr *vhdr
= NULL
;
hdr = map_sysmem(abootimg_addr(), sizeof(*hdr));
if (get_avendor_bootimg_addr() != -1)